Polish EIC data files - #2039
Conversation
|
@scarlehoff @Radonirinaunimi @RoyStegeman I think we should probably have a |
|
Thanks, I'll have a closer look later, but I agree that, if it makes sense to have multiple filter utils with e.g. some corresponding to only a single experiment, it would be good to have a |
|
Thanks so much for this @comane!
Yes, something along that line should definitely be adopted, and as a matter of fact I was planning to discuss with you (later this week) about the main utils that were/are required in the datasets you implemented in order to draft something. In this respect, as far as this PR is concerned, you could already move |
|
@comane, @RoyStegeman, given that these Athena share quite a lot of the functions with the other EIC projections, I also fixed them here. I therefore renamed the module from |
|
Please rebase so the tests will pass |
1dc9baf to
ec7c090
Compare
Radonirinaunimi
left a comment
There was a problem hiding this comment.
@comane I think this is done now, please merge if you are fine with this.
|
thanks @Radonirinaunimi and @RoyStegeman for reviewing! |
3b6cf1d to
ee8921f
Compare
|
You only force-pushed your local changes. I still have the commits from the review locally, would you like me to push those? |
|
Yes please, I might have done a mess. |
ee8921f to
3b6cf1d
Compare
Co-authored-by: Roy Stegeman <roystegeman@live.nl>
3b6cf1d to
f56203d
Compare
This PR aims at polishing the ATHENA data files.
Things that are done:
rawdatafolderpd.read_excelathena_utils.pyfile so as to minimise repeated code.