refactor NPLinker class#256
Merged
Merged
Conversation
This was referenced Jun 10, 2024
Merged
Member
Author
450f78d to
916e1c3
Compare
e9776df to
ea42a68
Compare
gcroci2
reviewed
Jun 14, 2024
| - MolecularFamily | ||
| self, objects: Sequence[BGC], scoring_method: str, **scoring_params | ||
| ) -> LinkGraph: ... | ||
| @overload |
Contributor
There was a problem hiding this comment.
I didn't know this decorator. Very handy!
gcroci2
approved these changes
Jun 14, 2024
916e1c3 to
984d72b
Compare
ea42a68 to
e7f0420
Compare
Merged
Member
Author
Merge activity
|
984d72b to
3f997ff
Compare
- remove unused method `scoring_method` - refactor the method `get_links`
- simplify the `conftest.py` - remove unused functions - add tests for `get_link`
e7f0420 to
155f7f8
Compare
|
This was referenced Jun 17, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally, it's ready to refactor the main class
NPLinker.It's better to review in the order of commits.
It's necessary to add some new methods to this class, e.g. pickling data, but they will be added in next PRs. When pickling data is done, then it's ready to start the dev of webapp.