improving type hints and usage of abc#259
Merged
Merged
Conversation
This was referenced Jun 17, 2024
Merged
Merged
Merged
Member
Author
Registering as virtual class can avoid metclass conflicts. However, it's not an issue we need to worry in this codebase, since all concrete classes, e.g. AntismashBGCLoader, inherit only one base class instead of multiple classes that have different metaclasses. Using inheritance of abstract class is more straightforward and explict.
524ab08 to
d5e1faa
Compare
Merged
|
gcroci2
approved these changes
Jun 20, 2024
gcroci2
left a comment
Contributor
There was a problem hiding this comment.
We reviewed it together live
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quite some small misc changes, better to review by commits.