Hide viewer buttons when roto/tracker properties panel is minimized - #748
Merged
Merged
Conversation
- addresses issue commented in #745 (review) - when panel maximized, buttons are displayed even if viewer is not in render path (see #744 for an explanation of that feature). This is not 100% satisfcatory, but better than before IMHO - minimized() and maximized() were originally two separate signals (in NodeSettingsPanel), so I kept it that way, but we could have simpler definitions of NodeGui::onSettingsPanelMinimized() and NodeGui::onSettingsPanelMaximized() that simply call NodeGui::onSettingsPanelClosed(true) or NodeGui::onSettingsPanelClosed(false).
devernay
marked this pull request as draft
January 11, 2022 01:51
Member
Author
|
still an issue: when panel is minimize but node is selected in the nodegraph, the buttons are displayed |
- maximize properties panel when double-clicking a node in the nodegraph - do not show the viewer buttons if a node is selected in the nodegraph but has its properties panel minimized
|
|
||
| QObject::connect( this, SIGNAL(closeChanged(bool)), NodeUi.get(), SLOT(onSettingsPanelClosedChanged(bool)) ); | ||
| QObject::connect( this, SIGNAL(minimized()), NodeUi.get(), SLOT(onSettingsPanelMinimized(bool)) ); | ||
| QObject::connect( this, SIGNAL(maximized()), NodeUi.get(), SLOT(onSettingsPanelMaximized(bool)) ); |
Member
There was a problem hiding this comment.
We might have an oopsie here (at least in Qt5)
QObject::connect: No such slot Natron::NodeGui::onSettingsPanelMinimized(bool) in ../../Gui/NodeSettingsPanel.cpp:91
QObject::connect: No such slot Natron::NodeGui::onSettingsPanelMaximized(bool) in ../../Gui/NodeSettingsPanel.cpp:92
QObject::connect: No such slot Natron::NodeGui::onSettingsPanelMinimized(bool) in ../../Gui/NodeSettingsPanel.cpp:91
QObject::connect: No such slot Natron::NodeGui::onSettingsPanelMaximized(bool) in ../../Gui/NodeSettingsPanel.cpp:92
Member
Author
There was a problem hiding this comment.
Thank you! These lines are useless
YakoYakoYokuYoku
requested changes
Jan 11, 2022
YakoYakoYokuYoku
left a comment
Member
There was a problem hiding this comment.
Aside from that bad connection I could confirm that this works.
Niik-l
pushed a commit
to Niik-l/Natron
that referenced
this pull request
Apr 8, 2026
…atronGitHub#748) - addresses issue commented in [NatronGitHub#745 (review)](NatronGitHub#745 (review)) - when panel is maximized, buttons are displayed even if viewer is not in render path (see NatronGitHub#744 for an explanation of that feature). This is not 100% satisfactory, but better than before IMHO - do not show the viewer buttons if a node is selected in the nodegraph but has its properties panel minimized - maximize properties panel when double-clicking a node in the nodegraph - minimized() and maximized() were originally two separate signals (in NodeSettingsPanel), so I kept it that way, but we could have simpler definitions of NodeGui::onSettingsPanelMinimized() and NodeGui::onSettingsPanelMaximized() that simply call NodeGui::onSettingsPanelClosed(true) or NodeGui::onSettingsPanelClosed(false).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (Check one of the boxes below)
What does this pull request do?
Show a few screenshots (if this is a visual change)
N/A
Have you tested your changes (if applicable)? If so, how?