Skip to content

Add Pong example#403

Open
PoloNX wants to merge 4 commits into
NazaraEngine:mainfrom
PoloNX:main
Open

Add Pong example#403
PoloNX wants to merge 4 commits into
NazaraEngine:mainfrom
PoloNX:main

Conversation

@PoloNX

@PoloNX PoloNX commented Jul 25, 2023

Copy link
Copy Markdown

I'm polonx on NaN

@CLAassistant

CLAassistant commented Jul 25, 2023

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codecov

codecov Bot commented Jul 27, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.65%. Comparing base (532d606) to head (16cc3d9).
Report is 2 commits behind head on main.

❗ Current head 16cc3d9 differs from pull request most recent head de4b846. Consider uploading reports for the commit de4b846 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
- Coverage   29.64%   28.65%   -0.99%     
==========================================
  Files        1126      904     -222     
  Lines       60777    47891   -12886     
  Branches    15101    13312    -1789     
==========================================
- Hits        18015    13722    -4293     
+ Misses      42519    34023    -8496     
+ Partials      243      146      -97     

see 1127 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47942b2...de4b846. Read the comment docs.

@PoloNX

PoloNX commented Jul 27, 2023

Copy link
Copy Markdown
Author

std::format is the problem. It's weird because I added this set_languages("c++20") in the xmake.lua

@SirLynix

Copy link
Copy Markdown
Contributor

C++20 is not well supported by the ecosystem, which is why you shouldn't use it for now

@PoloNX

PoloNX commented Jul 27, 2023

Copy link
Copy Markdown
Author

Normally it's good

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants