Repository navigation
Conversation
xokdvium
reviewed
Oct 9, 2026
xokdvium
reviewed
Oct 9, 2026
Fail when Brotli needs more input at EOF instead of looping forever. Accept empty input, matching the other decompressors. Test empty input, truncation and incremental decoding. Assisted-by: Codex (GPT-6-Astra)
iamanaws
force-pushed
the
fix/brotli-truncated-input
branch
from
October 11, 2026 13:12
3b04262 to
7a55fd1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Empty or truncated Brotli input can make decompression loop indefinitely.
The decoder requests more input, but finish() keeps retrying without any.
Context
Throw CompressionError when Brotli requests more input during finish(),
when the caller has signaled that no more bytes will arrive.
Requests for more input during normal streaming remain valid.
Add regression tests for empty and truncated input through both
decompression APIs.
Validation: 820 libutil tests passed, one skipped. Formatting passed.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.