You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Set proxy config for daemon during installation on Darwin - #8624
The macOS installer does not set the HTTP proxies for nix-daemon as like on Linux.
This may fail the downloading in certain environment.
This PR addresses the issue by setting the Launch Daemon plist file with the values read from environment variables.
Context
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
agreed on idea
agreed on implementation strategy
tests, as appropriate
functional tests - tests/**.sh
unit tests - src/*/tests
integration tests - tests/nixos/*
documentation in the manual
documentation in the internal API docs
code and comments are self-explanatory
commit message explains why the change was made
new feature or incompatible change: updated release notes
it looks like @rrbutani started some work to improve how this is handled for systemd in rrbutani@d2d2a3e (and commit message suggests they may also have/intend a commit adding a macOS equivalent on top of that work)
a few months ago the systemd equivalent received a fix for some edge-case escaping issues (not sure, off the top of my head, if this is systemd idiomatic or would also apply to launchd plists) in: Add escape for systemd service in installer script #7598
I saw a few comments on the downside of adopting whatever settings were active at install:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The macOS installer does not set the HTTP proxies for nix-daemon as like on Linux.
This may fail the downloading in certain environment.
This PR addresses the issue by setting the Launch Daemon plist file with the values read from environment variables.
Context
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*Priorities
Add 👍 to pull requests you find important.