Skip to content

Set proxy config for daemon during installation on Darwin - #8624

Open
laozc wants to merge 1 commit into
NixOS:masterfrom
laozc:proxy-darwin
Open

laozc wants to merge 1 commit into
NixOS:masterfrom
laozc:proxy-darwin

Conversation

@laozc

@laozc laozc commented Jul 1, 2023

Copy link
Copy Markdown

Motivation

The macOS installer does not set the HTTP proxies for nix-daemon as like on Linux.
This may fail the downloading in certain environment.
This PR addresses the issue by setting the Launch Daemon plist file with the values read from environment variables.

Context

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests - tests/nixos/*
  • documentation in the manual
  • documentation in the internal API docs
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or incompatible change: updated release notes

Priorities

Add 👍 to pull requests you find important.

Signed-off-by: Zhongcheng Lao <laozhongcheng@gmail.com>
@laozc
laozc requested a review from edolstra as a code owner July 1, 2023 14:28
@roberth roberth added installer macos Nix on macOS, aka OS X, aka darwin labels Jul 1, 2023
@abathur

abathur commented Jul 1, 2023

Copy link
Copy Markdown
Member

Just connecting dots:

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

installer macos Nix on macOS, aka OS X, aka darwin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants