Skip to content

python3.pkgs.rpy2: fix tests with pandas 1.x, 3.2.5 -> 3.2.6 - #82773

Merged
timokau merged 2 commits into
NixOS:masterfrom
timokau:rpy2-pandas-1.x
Mar 17, 2020
Merged

python3.pkgs.rpy2: fix tests with pandas 1.x, 3.2.5 -> 3.2.6#82773
timokau merged 2 commits into
NixOS:masterfrom
timokau:rpy2-pandas-1.x

Conversation

@timokau

@timokau timokau commented Mar 17, 2020 •
edited
Loading

Copy link
Copy Markdown
Member
Motivation for this change

The python3.pkgs.rpy2 build was broken by a recent update to pandas. A fix is already upstream and just needs to be backported. While I'm at it I also included a version bump to the latest released version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
timokau requested review from FRidh and jonringer as code owners March 17, 2020 11:00
@ofborg ofborg Bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 17, 2020
@ofborg
ofborg Bot requested a review from joelmo March 17, 2020 11:09
@ofborg ofborg Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 17, 2020
@timokau
timokau merged commit 4ad4523 into NixOS:master Mar 17, 2020
@timokau
timokau deleted the rpy2-pandas-1.x branch March 17, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh
@jonringer jonringer Awaiting requested review from jonringer
@joelmo joelmo Awaiting requested review from joelmo

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@timokau