Skip to content

mozwire: init at 0.4.1 - #95754

Merged
zowoq merged 2 commits into
NixOS:masterfrom
siraben:mozwire
Aug 19, 2020
Merged

mozwire: init at 0.4.1#95754
zowoq merged 2 commits into
NixOS:masterfrom
siraben:mozwire

Conversation

@siraben

@siraben siraben commented Aug 18, 2020 •
edited
Loading

Copy link
Copy Markdown
Member
Motivation for this change

Add mozwire.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siraben siraben changed the title Add mozwire mozwire: init Aug 18, 2020
@siraben siraben changed the title mozwire: init mozwire: init at 0.4.1 Aug 18, 2020
@siraben

siraben commented Aug 18, 2020

Copy link
Copy Markdown
Member Author

@GrahamcOfBorg build mozwire

@siraben

siraben commented Aug 18, 2020

Copy link
Copy Markdown
Member Author

@infinisil looks good to merge?

@siraben

siraben commented Aug 18, 2020

Copy link
Copy Markdown
Member Author

@GrahamcOfBorg build mozwire

@ofborg ofborg Bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 18, 2020
zowoq
zowoq reviewed Aug 18, 2020
View reviewed changes

@zowoq zowoq left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the commits:

mozwire: init at 0.4.1
maintainers: add nilsirl

Comment thread pkgs/tools/networking/mozwire/default.nix Outdated
Comment thread pkgs/tools/networking/mozwire/default.nix Outdated
Comment thread pkgs/tools/networking/mozwire/default.nix Outdated
Comment thread pkgs/tools/networking/mozwire/default.nix Outdated
Comment thread pkgs/tools/networking/mozwire/default.nix Outdated
@siraben

siraben commented Aug 19, 2020

Copy link
Copy Markdown
Member Author

@GrahamcOfBorg build mozwire

zowoq
zowoq reviewed Aug 19, 2020
View reviewed changes

@zowoq zowoq left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the darwin changes into the original commit.

Comment thread pkgs/tools/networking/mozwire/default.nix Outdated
Comment thread pkgs/tools/networking/mozwire/default.nix Outdated
Comment thread pkgs/top-level/all-packages.nix Outdated
@siraben
siraben requested a review from zowoq August 19, 2020 12:13
zowoq
zowoq approved these changes Aug 19, 2020
View reviewed changes

@zowoq zowoq left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds/runs on darwin.

@zowoq
zowoq merged commit 12a9e5f into NixOS:master Aug 19, 2020
@siraben
siraben deleted the mozwire branch August 19, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zowoq zowoq zowoq approved these changes

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siraben @zowoq @NilsIrl