Skip to content

[Places] Add basic level category - #399

Merged
Victor Schappert (vcschapp) merged 11 commits into
devfrom
jonahadkins-blc
Oct 8, 2025
Merged

Victor Schappert (vcschapp) merged 11 commits into
devfrom
jonahadkins-blc

Conversation

@jonahadkins

@jonahadkins Jonah Adkins (jonahadkins) commented Oct 7, 2025 •

Copy link
Copy Markdown
Contributor

B. Related MINOR change steps

  • Adds a new string column called basic_category.

C. Public documentation and messaging plan

tbd

Description

As part of our proposal to improve the current place categorization system in the Places theme, we are introducing a new column calledbasic_category.

The basic level category of a place. At present this is a mapping of the categories.primary entry to a new, simplified name. This mapping can be 1:1 or M:1 from the existing categories.primary entry. If the entry is currently empty in categories.primary, this entry will be empty. The full list of basic level categories is available at:(todo)

This new system reduces the current list of ~2100 category names down to ~430 categories.

This type of categorization is a cognitive science model that is relevant for taxonomy and ontology development that shows the most broadest and general category name that is most often found in the middle of a general-to-specific hierarchy, with generalization proceeding upward and specialization proceeding downward. This category level will be in the hierarchy but can also be pulled out and used for data visualization, matching, grouping similar places for benchmarking

Additionally, a comprehensive analysis of the existing taxonomy and several 3P taxonomies was completed to generate the current list.

Reference

#359
#329
#328
#39

Testing

this is a simple string column addition

TODO.

Checklist

  1. Add relevant examples.
  2. Add relevant counterexamples.
  3. Update any counterexamples that became obsolete. For example, if a counterexample uses property A but is not intended to test property A's validity, and you made a schema change that invalidates property A in that counterexample, fix the counterexample to align it with your schema change.
  4. Update in-schema documentation using plain English written in complete sentences, if an update is required.
  5. Update Docusaurus documentation, if an update is required.
  6. Review change with Overture technical writer to ensure any advanced documentation needs will be taken care of, unless the change is trivial and would not affect the documentation.

Documentation website

Update the hyperlink below to put the pull request number in.

Docs preview for this PR.

Comment thread schema/places/defs.yaml Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments in the diff.

In addition, would you please:

  • Replace all TODO items with actual descriptions, in the PR description and in the diff text.
  • Add representative examples and a counterexamples.

Comment thread schema/places/place.yaml Outdated
Comment thread schema/places/place.yaml Outdated
@jonahadkins Jonah Adkins (jonahadkins) added the change type - minor 🤏 Minor schema change. See https://lf-overturemaps.atlassian.net/wiki/x/GgDa label Oct 7, 2025
Comment thread schema/places/place.yaml
Comment thread schema/places/place.yaml Outdated
Comment thread schema/places/place.yaml
Comment thread counterexamples/places/bad-basic-category.yaml
Comment thread schema/places/place.yaml

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

a.k.a. SHIP IT!

@TristanDiet-TomTom
TristanDiet-TomTom self-requested a review October 8, 2025 15:15
@vcschapp
Victor Schappert (vcschapp) merged commit 02b8439 into dev Oct 8, 2025
4 checks passed
@vcschapp
Victor Schappert (vcschapp) deleted the jonahadkins-blc branch October 8, 2025 15:21
@vcschapp Victor Schappert (vcschapp) changed the title [draft][Places] add basic level category [Places] Add basic level category Oct 8, 2025
Victor Schappert (vcschapp) pushed a commit that referenced this pull request Oct 17, 2025
This commit brings the Pydantic model back in sync with the Jonah's
recent change to add `basic_category` to Place, part of the broader
Places usability initiative driven by the Places TF.

It is based on #399.
Victor Schappert (vcschapp) pushed a commit that referenced this pull request Oct 17, 2025
* add basic_level_category column to schema

* add basic_level_category definition

* Update name/types for column

* Update column name

* add example

* add counter example

* fix typo

* update ref/types

* remove unnecessary change

* fix counter example

* update description
Victor Schappert (vcschapp) pushed a commit that referenced this pull request Nov 26, 2025
This commit brings the Pydantic model back in sync with the Jonah's
recent change to add `basic_category` to Place, part of the broader
Places usability initiative driven by the Places TF.

It is based on #399.
Victor Schappert (vcschapp) pushed a commit that referenced this pull request Dec 4, 2025
This commit brings the Pydantic model back in sync with the Jonah's
recent change to add `basic_category` to Place, part of the broader
Places usability initiative driven by the Places TF.

It is based on #399.
Patryk (patryklikus-tomtom) pushed a commit to patryklikus-tomtom/OvertureMaps-schemas that referenced this pull request Dec 4, 2025
* add basic_level_category column to schema

* add basic_level_category definition

* Update name/types for column

* Update column name

* add example

* add counter example

* fix typo

* update ref/types

* remove unnecessary change

* fix counter example

* update description

This branch was previously deployed

1 inactive deployment
staging — 7f7f0d74 Deployed Oct 8, 2025 by jonahadkins via publish #1139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change type - minor 🤏 Minor schema change. See https://lf-overturemaps.atlassian.net/wiki/x/GgDa

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants