Repository navigation
[Places] Add basic level category - #399
Merged
Merged
Conversation
Jonah Adkins (jonahadkins)
temporarily deployed
to
staging
October 7, 2025 15:20 — with
GitHub Actions
Inactive
Victor Schappert (vcschapp)
requested changes
Oct 7, 2025
Victor Schappert (vcschapp)
left a comment
Collaborator
There was a problem hiding this comment.
Some comments in the diff.
In addition, would you please:
- Replace all TODO items with actual descriptions, in the PR description and in the diff text.
- Add representative examples and a counterexamples.
Jonah Adkins (jonahadkins)
temporarily deployed
to
staging
October 7, 2025 18:36 — with
GitHub Actions
Inactive
Jonah Adkins (jonahadkins)
temporarily deployed
to
staging
October 7, 2025 18:36 — with
GitHub Actions
Inactive
Jonah Adkins (jonahadkins)
temporarily deployed
to
staging
October 7, 2025 19:18 — with
GitHub Actions
Inactive
Jonah Adkins (jonahadkins)
temporarily deployed
to
staging
October 7, 2025 19:20 — with
GitHub Actions
Inactive
Jonah Adkins (jonahadkins)
temporarily deployed
to
staging
October 7, 2025 19:22 — with
GitHub Actions
Inactive
Victor Schappert (vcschapp)
requested changes
Oct 7, 2025
Jonah Adkins (jonahadkins)
temporarily deployed
to
staging
October 8, 2025 00:13 — with
GitHub Actions
Inactive
Jonah Adkins (jonahadkins)
temporarily deployed
to
staging
October 8, 2025 00:14 — with
GitHub Actions
Inactive
Jonah Adkins (jonahadkins)
temporarily deployed
to
staging
October 8, 2025 00:17 — with
GitHub Actions
Inactive
Victor Schappert (vcschapp)
previously approved these changes
Oct 8, 2025
Jonah Adkins (jonahadkins)
temporarily deployed
to
staging
October 8, 2025 14:46 — with
GitHub Actions
Inactive
Jacob Wasserman (jwass)
approved these changes
Oct 8, 2025
TristanDiet-TomTom
self-requested a review
October 8, 2025 15:15
TristanDiet-TomTom
approved these changes
Oct 8, 2025
2 tasks
Victor Schappert (vcschapp)
pushed a commit
that referenced
this pull request
Oct 17, 2025
This commit brings the Pydantic model back in sync with the Jonah's recent change to add `basic_category` to Place, part of the broader Places usability initiative driven by the Places TF. It is based on #399.
Victor Schappert (vcschapp)
pushed a commit
that referenced
this pull request
Oct 17, 2025
* add basic_level_category column to schema * add basic_level_category definition * Update name/types for column * Update column name * add example * add counter example * fix typo * update ref/types * remove unnecessary change * fix counter example * update description
Victor Schappert (vcschapp)
pushed a commit
that referenced
this pull request
Nov 26, 2025
This commit brings the Pydantic model back in sync with the Jonah's recent change to add `basic_category` to Place, part of the broader Places usability initiative driven by the Places TF. It is based on #399.
2 of 6 tasks
Victor Schappert (vcschapp)
pushed a commit
that referenced
this pull request
Dec 4, 2025
This commit brings the Pydantic model back in sync with the Jonah's recent change to add `basic_category` to Place, part of the broader Places usability initiative driven by the Places TF. It is based on #399.
Patryk (patryklikus-tomtom)
pushed a commit
to patryklikus-tomtom/OvertureMaps-schemas
that referenced
this pull request
Dec 4, 2025
* add basic_level_category column to schema * add basic_level_category definition * Update name/types for column * Update column name * add example * add counter example * fix typo * update ref/types * remove unnecessary change * fix counter example * update description
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
B. Related MINOR change steps
stringcolumn calledbasic_category.C. Public documentation and messaging plan
tbd
Description
As part of our proposal to improve the current place categorization system in the Places theme, we are introducing a new column called
basic_category.The basic level category of a place. At present this is a mapping of the
categories.primaryentry to a new, simplified name. This mapping can be 1:1 or M:1 from the existingcategories.primaryentry. If the entry is currently empty incategories.primary, this entry will be empty. The full list of basic level categories is available at:(todo)This new system reduces the current list of ~2100 category names down to ~430 categories.
Additionally, a comprehensive analysis of the existing taxonomy and several 3P taxonomies was completed to generate the current list.
Reference
#359
#329
#328
#39
Testing
this is a simple string column addition
TODO.
Checklist
Abut is not intended to test propertyA's validity, and you made a schema change that invalidates propertyAin that counterexample, fix the counterexample to align it with your schema change.Documentation website
Update the hyperlink below to put the pull request number in.
Docs preview for this PR.