[9.0][FIX]web_m2x_options: prevent popup to open web badger is deleted#554
Closed
zakiuu wants to merge 1 commit into
Closed
[9.0][FIX]web_m2x_options: prevent popup to open web badger is deleted#554zakiuu wants to merge 1 commit into
zakiuu wants to merge 1 commit into
Conversation
Author
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current behavior is when you try deleting an element from a
many2many_tagthat hasoptions={'open': true}the popup still show up even the element is deleted.The
$(ev.currentTarget).data('id')always returns a valid ID, hence the action is executed.With this fix I've used the
($(ev.target).data('id')instead and checked wether I've a value inidor not.So the expected bahavior now: when deleting the tag the popup should no show up any more.