Skip to content

[12.0][IMP] web_pwa_oca: Drop BeforeInstallPrompt - #1759

Merged
OCA-git-bot merged 4 commits into
OCA:12.0from
Tecnativa:12.0-imp-web_pwa_oca-install
Dec 11, 2020
Merged

[12.0][IMP] web_pwa_oca: Drop BeforeInstallPrompt#1759
OCA-git-bot merged 4 commits into
OCA:12.0from
Tecnativa:12.0-imp-web_pwa_oca-install

Conversation

@Tardo

@Tardo Tardo commented Dec 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

BeforeInstallPromptEvent is deprecated. See w3c/manifest#836

Currently only chrome support it... and can't be used for the purpose that is used in the module.

cc @Tecnativa TT23822

ping @thomaspaulb

@OCA-git-bot

OCA-git-bot commented Dec 9, 2020

Copy link
Copy Markdown
Contributor

Hi @eLBati,
some modules you are maintaining are being modified, check this out!

thomaspaulb
thomaspaulb approved these changes Dec 10, 2020
View reviewed changes

@thomaspaulb thomaspaulb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, I didn't know about that. I'm in agreement, it makes the module simpler also.

Comment thread web_pwa_oca/README.rst Outdated
Comment thread web_pwa_oca/static/description/index.html
@Tardo
Tardo force-pushed the 12.0-imp-web_pwa_oca-install branch from b3ba1fd to 4a293d8 Compare December 11, 2020 01:12
pedrobaeza
pedrobaeza reviewed Dec 11, 2020
View reviewed changes
Comment thread web_pwa_oca/README.rst Outdated
@legalsylvain
[FIX] web_pwa_oca : do not raise an error if service workers is disab…
a2e801a 
…led (only log). Otherwise, odoo is unavailable in private mode with Firefox Browser
@legalsylvain

legalsylvain commented Dec 11, 2020

Copy link
Copy Markdown
Contributor

Hi @Tardo and Tecnativa team. First, thanks a lot for this usefull module, I use since a month in production.
Recently (I guess since #1628) I have a problem with Firefox + private mode.

i so made a patch on the top of your current PR to fix it. Tecnativa#2
Could you merge it, if it's OK for you ?

(I PR against your PR to avoid conflict, because you are changing the line I want to change).

thanks !

pedrobaeza and others added 2 commits December 11, 2020 14:41
@pedrobaeza
Merge pull request #2 from legalsylvain/12.0-FIX-web_pwa_oca-no-error…
191a6e0 
…-raised-firefox-private-mode

[FIX] web_pwa_oca : do not raise an error if service workers is disabled (only log). Otherwise, odoo is unavailable in private mode with Firefox Browser
@Tardo
[IMP] web_pwa_oca: Readme
076ca81
@Tardo

Tardo commented Dec 11, 2020

Copy link
Copy Markdown
Member Author

Changes done

@pedrobaeza pedrobaeza added this to the 12.0 milestone Dec 11, 2020
@pedrobaeza

pedrobaeza commented Dec 11, 2020

Copy link
Copy Markdown
Member

/ocabot merge major

@OCA-git-bot

OCA-git-bot commented Dec 11, 2020

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-1759-by-pedrobaeza-bump-major, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 29a1836 into OCA:12.0 Dec 11, 2020
@OCA-git-bot

OCA-git-bot commented Dec 11, 2020

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at c3c44ae. Thanks a lot for contributing to OCA. ❤️

@Tardo Tardo mentioned this pull request Dec 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomaspaulb thomaspaulb thomaspaulb approved these changes
@pedrobaeza pedrobaeza pedrobaeza approved these changes
+1 more reviewer
@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉

Projects

None yet

Milestone

12.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Tardo @OCA-git-bot @legalsylvain @pedrobaeza @thomaspaulb @marcelsavegnago