[16.0][ADD] web_responsive_attachment_preview#3058
Open
hbrunn wants to merge 1 commit into
Open
Conversation
flotho
approved these changes
Jan 15, 2025
flotho
left a comment
Member
There was a problem hiding this comment.
Thanks,
Tested on runboat, make sense
LGTM
Member
|
any conflict with #2695 ? |
Member
Author
|
they do basically the same thing, so one or the other should be merged. People on the other PR didn't seem enthusiastic to have it in the main module, that's why I added it as extra one |
Member
|
I think that a exclusive view for reviewing invoices with the preview should exist, but most of the work with invoices shouldn't show the preview, as you don't need it, and you have to go to bottom to check the chatter, which is what you use most. |
|
This PR is highly appreciated by our customers so It hink it should be part of the standard package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module restores the attachment preview on the right side of forms for example on invoices by standard Odoo when using
web_responsive. The chatter in that case is always below the form. Note Odoo's cutoff is 1534px width, smaller screens never show the preview.Use case is a controller going through invoices to confirm them, in that case it's pretty annoying to have to open the attachments and then the preview of the invoice's pdf manually a hundred times a day.
Technically, it removes this patch. (I still think web_responsive does too much at once and should be split up into several ones)