Skip to content

[FIX]web_responsive: fixed the issue of file viewer not display in form view.#3122

Open
parvezqureshi wants to merge 1 commit into
OCA:17.0from
parvezqureshi:17.0-fix-web_responsive
Open

[FIX]web_responsive: fixed the issue of file viewer not display in form view.#3122
parvezqureshi wants to merge 1 commit into
OCA:17.0from
parvezqureshi:17.0-fix-web_responsive

Conversation

@parvezqureshi

@parvezqureshi parvezqureshi commented Mar 12, 2025

Copy link
Copy Markdown

The attachments of customer invoices appear automatically (see screenshot). When we install oca/web/web_responsive, the attachments do not appear automatically (see screenshot). This is on a computer screen of course.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @Tardo, @SplashS,
some modules you are maintaining are being modified, check this out!

@parvezqureshi parvezqureshi force-pushed the 17.0-fix-web_responsive branch from fd7d4bc to d4a58bf Compare March 12, 2025 07:13

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done on purpose. We don't want the preview to appear automatically. See #2745 #2795.

If you want to enable it, please include a system or user option.

@pedrobaeza pedrobaeza added this to the 17.0 milestone Mar 12, 2025
@parvezqureshi

Copy link
Copy Markdown
Author

@cvinh please review.

@cvinh

cvinh commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

@cvinh please review.

Thanks @parvezqureshi please include a setup by user if someone wants attachment to open automatically or not... default =False (thanks to @pedrobaeza )

Please remove the screenshots, there are personal data in them... I think the reviewers understood the purpose

@parvezqureshi parvezqureshi force-pushed the 17.0-fix-web_responsive branch 6 times, most recently from 7fa550c to 19d2832 Compare March 12, 2025 09:18
<data>
<field name="action_id" position="after">
<field name="is_redirect_home" invisible="action_id" />
<field name="display_file_viewer" />

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems it has an incorrect indentation

@cvinh cvinh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you :

  • improve the README explaining this new functionality
  • change your commit comment with [IMP] instead of [FIX]

Comment thread web_responsive/models/res_users.py Outdated
store=True,
readonly=False,
)
display_file_viewer = fields.Boolean()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a help to explain what this field does

@cvinh

cvinh commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

cc @vehi-invitu

@vehi-invitu vehi-invitu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The setup is missing in base.view_users_form_simple_modif view

@hbrunn, what do you about this setup user ? It should be good solution for your PR
#3058

@parvezqureshi parvezqureshi force-pushed the 17.0-fix-web_responsive branch from 19d2832 to cabeea5 Compare March 13, 2025 05:17
@parvezqureshi parvezqureshi force-pushed the 17.0-fix-web_responsive branch from cabeea5 to 725185e Compare March 13, 2025 05:28

@cvinh cvinh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cvinh cvinh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me

@vehi-invitu vehi-invitu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. It's good for me !

@jcdrubay

jcdrubay commented Apr 22, 2025

Copy link
Copy Markdown

In the search view, from google chrome on desktop, when rendering the page, the selection field for Custom Group By as rendering with very small font-size (even after refresh)

http://oca-web-17-0-pr3122-725185e11078.runboat.odoo-community.org/web?reload=true#action=69&model=res.users&view_type=kanban&menu_id=60&cids=1

image

@cvinh

cvinh commented May 14, 2025

Copy link
Copy Markdown
Contributor

In the search view, from google chrome on desktop, when rendering the page, the selection field for Custom Group By as rendering with very small font-size (even after refresh)

http://oca-web-17-0-pr3122-725185e11078.runboat.odoo-community.org/web?reload=true#action=69&model=res.users&view_type=kanban&menu_id=60&cids=1

image

@parvezqureshi can you check this please ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants