Repository navigation
[20.0][MIG] pms_website_sale: Migration to 20.0 - #481
Open
weinni2000 wants to merge 4 commits into
Open
weinni2000 wants to merge 4 commits into
weinni2000 wants to merge 4 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
The following commit authors need to sign the Contributor License Agreement: |
max3903
requested changes
Nov 16, 2026
max3903
left a comment
Member
There was a problem hiding this comment.
Left to fix
- Tests and Runboat fail: there is no 20.0 wheel for
pms_sale. Addtest-requirements.txtgit pins for #477 and #480. - CLA is red for
36848414+AmmarOfficewalaSerpentCS@users.noreply.github.com. That author needs to sign, or the commit needs a signed author. -
property_add_to_cartcreates a reservation without the overlap check, andcheck_availabilityignores stage New, so two carts can take the same dates. Re-check before create and count those holds. - The listing date domain drops reservations that end after the search window. Use start <= end and stop >= start.
-
reservation_type_idis not checked against the property, and guest dicts are passed through. Accept only a type for that property (or a global type) and only name, phone, and email.
Member
|
/ocabot migration pms_website_sale |
Assisted-by: Claude Code (deepseek-flash[1m])
weinni2000
force-pushed
the
20.0-mig-pms_website_sale
branch
from
November 17, 2026 07:27
34342a1 to
f51fe41
Compare
Author
|
Hi @AmmarOfficewalaSerpentCS, your original |
Author
|
All five items are addressed:
Local run of the full module suite passes (28 tests, tours included). |
Author
|
@max3903 the review items are fixed and pushed; could you take another look when the checks are green? (I cannot re-request the review through the API as a fork author.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
security/ir.model.access.csvtosecurity/ir.access.csv; thepublished-only property rule is now an
ir.accessrecord for portal users.request.websiteandget_current_website()are gone, userequest.env.website;can_access_from_current_website()is replaced by anexplicit
website_idcheck in the booking endpoint.start_tour(url_path), theurlkey on the tour registration is no longer read, so it is dropped.
website_published->is_published, and datetime searches use anactual datetime instead of a date-only string (new search semantics).
Note: the public part of the old published-only property rule is now the domain
of
access_pms_property_publicinpms_website, because Odoo 20 ORs permissiondomains.
Depends on #477 (
pms_sale) and #480 (pms_website).Migration changes only (diff after the pre-commit auto fixes): weinni2000#10
Assisted-by: Claude Code (deepseek-flash[1m])