Skip to content

[20.0][MIG] pms_website_sale: Migration to 20.0 - #481

Open
weinni2000 wants to merge 4 commits into
OCA:20.0from
weinni2000:20.0-mig-pms_website_sale
Open

weinni2000 wants to merge 4 commits into
OCA:20.0from
weinni2000:20.0-mig-pms_website_sale

Conversation

@weinni2000

@weinni2000 weinni2000 commented Nov 16, 2026 •

Copy link
Copy Markdown
  • Convert security/ir.model.access.csv to security/ir.access.csv; the
    published-only property rule is now an ir.access record for portal users.
  • Website API: request.website and get_current_website() are gone, use
    request.env.website; can_access_from_current_website() is replaced by an
    explicit website_id check in the booking endpoint.
  • Tours: Odoo 20 takes the starting URL from start_tour(url_path), the url
    key on the tour registration is no longer read, so it is dropped.
  • Tests: website_published -> is_published, and datetime searches use an
    actual datetime instead of a date-only string (new search semantics).

Note: the public part of the old published-only property rule is now the domain
of access_pms_property_public in pms_website, because Odoo 20 ORs permission
domains.

Depends on #477 (pms_sale) and #480 (pms_website).

Migration changes only (diff after the pre-commit auto fixes): weinni2000#10

Assisted-by: Claude Code (deepseek-flash[1m])

@oca-cla-bot

oca-cla-bot Bot commented Nov 16, 2026

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

CLA not signed

@max3903 max3903 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left to fix

  • Tests and Runboat fail: there is no 20.0 wheel for pms_sale. Add test-requirements.txt git pins for #477 and #480.
  • CLA is red for 36848414+AmmarOfficewalaSerpentCS@users.noreply.github.com. That author needs to sign, or the commit needs a signed author.
  • property_add_to_cart creates a reservation without the overlap check, and check_availability ignores stage New, so two carts can take the same dates. Re-check before create and count those holds.
  • The listing date domain drops reservations that end after the search window. Use start <= end and stop >= start.
  • reservation_type_id is not checked against the property, and guest dicts are passed through. Accept only a type for that property (or a global type) and only name, phone, and email.

@max3903

max3903 commented Nov 16, 2026

Copy link
Copy Markdown
Member

/ocabot migration pms_website_sale

@OCA-git-bot OCA-git-bot mentioned this pull request Nov 16, 2026
11 tasks
Assisted-by: Claude Code (deepseek-flash[1m])
@weinni2000
weinni2000 force-pushed the 20.0-mig-pms_website_sale branch from 34342a1 to f51fe41 Compare November 17, 2026 07:27
@weinni2000

Copy link
Copy Markdown
Author

Hi @AmmarOfficewalaSerpentCS, your original pms_website_sale commit is part of this 20.0 migration, and the CLA check fails for 36848414+AmmarOfficewalaSerpentCS@users.noreply.github.com. Could you sign at https://clabot.odoo-community.org/ (or have that address added to your company CLA)? Thanks!

@weinni2000

Copy link
Copy Markdown
Author

All five items are addressed:

Local run of the full module suite passes (28 tests, tours included).

@weinni2000

Copy link
Copy Markdown
Author

@max3903 the review items are fixed and pushed; could you take another look when the checks are green? (I cannot re-request the review through the API as a fork author.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants