Skip to content

fix: no external vocabularies#716

Merged
cristianvasquez merged 2 commits into
feature/4.2.0-rc.2from
fix/4.2.0-rc.2
Nov 27, 2024
Merged

fix: no external vocabularies#716
cristianvasquez merged 2 commits into
feature/4.2.0-rc.2from
fix/4.2.0-rc.2

Conversation

@cristianvasquez

Copy link
Copy Markdown
Contributor

fix: missing SHACL relations

fix: missing SHACL relations
@cristianvasquez

Copy link
Copy Markdown
Contributor Author

I've run the script to remove the redefinition of external vocabularies and generated the SHACL from the enterprise architect file.

@andreea-pasare

Copy link
Copy Markdown
Collaborator

Some minor comments that should not have an impact from a technical point of view:

  • I see some prefixes (related to rml) that are declared in the prefix section, but they are not used in the content part of the files.
  • Also, in the owl:imports section, there are some namespaces that do not use prefixes even if we have them declared previously.
    image

@andreea-pasare

Copy link
Copy Markdown
Collaborator

The namespaces for cpv and nuts should be manually changed. You can take those from a previous release candidate: 4.1.0-rc.2:
<sh:class rdf:resource="http://data.europa.eu/nuts/scheme/2021"/>
<sh:class rdf:resource="http://data.europa.eu/cpv/cpv"/>
Changes should be reflected in all RDF/TTL shape files where these codelists are referenced.

@cristianvasquez

Copy link
Copy Markdown
Contributor Author

The namespaces for cpv and nuts should be manually changed. You can take those from a previous release candidate: 4.1.0-rc.2: <sh:class rdf:resource="http://data.europa.eu/nuts/scheme/2021"/> <sh:class rdf:resource="http://data.europa.eu/cpv/cpv"/> Changes should be reflected in all RDF/TTL shape files where these codelists are referenced.

Thanks for the comments. Can you point out exactly what namespace needs to change?

@andreea-pasare

andreea-pasare commented Nov 25, 2024

Copy link
Copy Markdown
Collaborator

Every mention of the following two:
<sh:class rdf:resource="http://publications.europa.eu/resource/authority/nuts"/>
<sh:class rdf:resource="http://publications.europa.eu/resource/authority/cpv"/>

Should be replaced by:
<sh:class rdf:resource="http://data.europa.eu/nuts/scheme/2021"/>
<sh:class rdf:resource="http://data.europa.eu/cpv/cpv"/>

These modifications should also be reflected in the TTL files.

@cristianvasquez
cristianvasquez merged commit a82e07e into feature/4.2.0-rc.2 Nov 27, 2024
@cristianvasquez
cristianvasquez deleted the fix/4.2.0-rc.2 branch November 27, 2024 14:02
cristianvasquez added a commit that referenced this pull request Nov 27, 2024
fix: missing SHACL relations
cristianvasquez added a commit that referenced this pull request Jun 18, 2025
feat: add eInvoicing module and update related assets

- Added new `eInvoicing` folder with transformation files, SHACL shapes, convention reports, and glossary documents
- Updated configuration parameters, namespaces, and XML instances
- Replaced and cleaned up EA (.eap) files
- Fixed issues: #624, #688, #689, #716, #718
- Updated `transform_epo.yml` with path fixes and `priorVersion` set to 4.1.1
- Updated SHACL shapes to remove external vocabularies and fix missing relations
- Replaced outdated CPV and NUTS namespaces with current authoritative URIs
- Added README.md files for eAccess, eInvoicing, and eSubmission modules
- Updated main README.md to reference the new module
- Disabled transformation in `transform_epo.yml` for branch `develop`

Co-authored-by: Andreea Pasare <nicoleta.pasare@gmail.com>
Co-authored-by: github-actions <action@github.com>
Co-authored-by: MummiaDoug <achilles.dougalis@meaningfy.ws>
cristianvasquez added a commit that referenced this pull request Jun 25, 2025
- Added README.md files for eAccess, eInvoicing, eSubmission.
- Fixed issues #624, #688, #689, #716, #718, #720

* Replaced the namespaces:

<sh:class rdf:resource="[http://publications.europa.eu/resource/authority/nuts"/>](http://publications.europa.eu/resource/authority/nuts%22/%3E)
<sh:class rdf:resource="[http://publications.europa.eu/resource/authority/cpv"/>](http://publications.europa.eu/resource/authority/cpv%22/%3E)

To:
<sh:class rdf:resource="[http://data.europa.eu/nuts/scheme/2021"/>](http://data.europa.eu/nuts/scheme/2021%22/%3E)
<sh:class rdf:resource="[http://data.europa.eu/cpv/cpv"/>](http://data.europa.eu/cpv/cpv%22/%3E)
---------

Co-authored-by: andreea <nicoleta.pasare@gmail.com>
Co-authored-by: github-actions <action@github.com>
Co-authored-by: MummiaDoug <achilles.dougalis@meaningfy.ws>
Co-authored-by: Andreea Pasare <88081600+andreea-pasare@users.noreply.github.com>
andreea-pasare added a commit that referenced this pull request Oct 21, 2025
* updated eap file

* added eInvoicing folder; updated config parameters and namespaces; updated xml files

* Adding convention report and glossary files

* Adding transformation files

* chore: update SHACL shapes

* chore: add eInvoicing module

* Update transform_epo.yml

* fixed issues (#624, #688, #689)

* replaced EA file with new, updated version

* updated priorVersion to 4.1.1; updated paths in transform_epo.yml; updated xml files.

* Adding convention report and glossary files

* updated EA file (clean-up)

* updated EA file (clean-up)

* Added README.md files for eAccess, eInvoicing, eSubmission. Changed the README.md file under implementation.

* modified main README.md to include eInvoicing

* updated xml files

* Adding convention report and glossary files

* updated xml files

* Adding convention report and glossary files

* fixed typo in EA file; updated xml files

* Adding convention report and glossary files

* Adding transformation files

* fix: no external vocabularies (#718)

* fix: no external vocabularies
fix: missing SHACL relations

* Replaced the namespaces:

<sh:class rdf:resource="[http://publications.europa.eu/resource/authority/nuts"/>](http://publications.europa.eu/resource/authority/nuts%22/%3E)
<sh:class rdf:resource="[http://publications.europa.eu/resource/authority/cpv"/>](http://publications.europa.eu/resource/authority/cpv%22/%3E)

To:
<sh:class rdf:resource="[http://data.europa.eu/nuts/scheme/2021"/>](http://data.europa.eu/nuts/scheme/2021%22/%3E)
<sh:class rdf:resource="[http://data.europa.eu/cpv/cpv"/>](http://data.europa.eu/cpv/cpv%22/%3E)

* 4.0.2-rc2 (#719)

* updated eap file

* added eInvoicing folder; updated config parameters and namespaces; updated xml files

* Adding convention report and glossary files

* Adding transformation files

* chore: update SHACL shapes

* chore: add eInvoicing module

* Update transform_epo.yml

* fixed issues (#624, #688, #689)

* replaced EA file with new, updated version

* updated priorVersion to 4.1.1; updated paths in transform_epo.yml; updated xml files.

* Adding convention report and glossary files

* updated EA file (clean-up)

* updated EA file (clean-up)

* Added README.md files for eAccess, eInvoicing, eSubmission. Changed the README.md file under implementation.

* modified main README.md to include eInvoicing

* updated xml files

* Adding convention report and glossary files

* updated xml files

* Adding convention report and glossary files

* fixed typo in EA file; updated xml files

* Adding convention report and glossary files

* Adding transformation files

---------

Co-authored-by: andreea <nicoleta.pasare@gmail.com>
Co-authored-by: github-actions <action@github.com>
Co-authored-by: MummiaDoug <achilles.dougalis@meaningfy.ws>

* fix: no external vocabularies (#716) (#720)

fix: missing SHACL relations

* fix: no external vocabularies
fix: missing SHACL relations

* update metadata

* Release/5.0.0 (#789)

* Update transform_epo.yml

disable transformation for branch 'develop'

* added owl and shacl folders for all modules; updated readme files.

* postprocessing fix

* updated conceptual model file link in readme file; updated readme files for eAwarding and ePayment folders.

* release/5.1.0 (#796)

* added owl and shacl folders for all modules; updated readme files.

* postprocessing fix

* updated conceptual model file link in readme file; updated readme files for eAwarding and ePayment folders.

---------

Co-authored-by: Cristian <cristianvasquez@gmail.com>

* release/5.2.0 (#801)

* added owl and shacl folders for all modules; updated link to conceptual model file in readme file.

* chore: Remove re-definition, and fix imports

---------

Co-authored-by: Cristian <cristianvasquez@gmail.com>

* release/5.2.0 (#804)

* added owl and shacl folders for all modules; updated link to conceptual model file in readme file.

* chore: Remove re-definition, and fix imports

---------

Co-authored-by: Cristian <cristianvasquez@gmail.com>

---------

Co-authored-by: github-actions <action@github.com>
Co-authored-by: Cristian <cristianvasquez@gmail.com>
Co-authored-by: MummiaDoug <achilles.dougalis@meaningfy.ws>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants