Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
GetLayerDefn()andGetDefnRef()already hold a referene to the FeatureDefn, but the field defns you get out of it don't, so once the dataset or feature goes away they point at freed memory:Same thing with
GetGeomFieldDefn(0)- segfaults when callingGetSpatialRef().Reproduced 3.13.3 and master.
Fix
Make returned objects keep a Python reference to their parent:
FeatureDefn.GetFieldDefn/GetGeomFieldDefnkeep FeatureDefnFeature.GetFieldDefnRef/GetGeomFieldDefnRefkeep FeatureGeomFieldDefn.GetCoordinatePrecisionkeep GeomFieldDefnTests
Added
test_field_defn_use_after_layer_delandtest_field_defn_use_after_feature_delWhat are related issues/pull requests?
AI tool usage
Tasklist
Environment
Provide environment details, if relevant: