forked from RIOT-OS/RIOT
-
Notifications
You must be signed in to change notification settings - Fork 1
Cppcheck fixes #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thomaseichinger
wants to merge
24
commits into
OlegHahm:cppcheck_fixes
Choose a base branch
from
thomaseichinger:cppcheck_fixes
base: cppcheck_fixes
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cppcheck fixes #17
thomaseichinger
wants to merge
24
commits into
OlegHahm:cppcheck_fixes
from
thomaseichinger:cppcheck_fixes
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37d7d13 to
eaeaff1
Compare
Owner
|
Thanks, Thomas, for the patches. Could you add the rationales to the suppressions (according to our coding conventions this is required), please? |
5124edd to
079ffde
Compare
079ffde to
ba7b67f
Compare
Author
|
@OlegHahm fixed. |
98e38f5 to
5a12d89
Compare
d8b8fe5 to
24d8ca7
Compare
24d8ca7 to
ec97a94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.