Repository navigation
Conversation
noisersup
marked this pull request as ready for review
June 9, 2025 15:38
noisersup
enabled auto-merge (squash)
June 9, 2025 15:38
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a comprehensive test case file for the aggregation "$abs" operator, ensuring that the operator behaves correctly across various numeric types.
- Adds a new test file (abs.json) with cases for int, long, double, and decimal values
- Validates edge cases, including maximum, minimum, zero, and infinity values
chilagrow
reviewed
Jun 10, 2025
| "decimal" | ||
| ], | ||
| "$gt": { | ||
| "$numberLong": "-9223372036854775808" |
Collaborator
There was a problem hiding this comment.
$match is already using $type filter, why do you need this $gt condition? Can we remove it? $abs is able to handle numbers, null and missing field.
Collaborator
Author
There was a problem hiding this comment.
The absolute value of int64-min (-9223372036854775808), overflows int64, which results in error.
Collaborator
There was a problem hiding this comment.
I suggest matching specific _id that case. Because float64 could have a smaller valid number right?
chilagrow
reviewed
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #57.