Repository navigation
Improve compatibility and generation - #96
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves 3D Tiles renderer compatibility and dataset generation behavior by (1) optionally generating renderable root-tile content (to avoid “empty root” tilesets that some renderers won’t traverse) and (2) making the root geometricError default scale with the model’s size instead of using a fixed constant.
Changes:
- Generate an optional
root.b3dmfrom a coarsest whole-model OBJ and attach it astileset.root.content. - Change tileset root refinement to
"REPLACE"and derive--errorautomatically from model bounds when unspecified (default0). - Update CLI help text for
--errorto clarify behavior and units.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Obj2Tiles/Stages/TilingStage.cs | Adds optional root content generation and updates root tile refinement/content wiring. |
| Obj2Tiles/Program.cs | Derives default baseError from model bounds and prepares a compressed coarsest root mesh for tiling. |
| Obj2Tiles/Options.cs | Changes --error default to 0 and documents automatic derivation behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #93 #84