fix: write tracking to versandpakete table for UI visibility (#247)#248
Open
Avatarsia wants to merge 1 commit into
Open
fix: write tracking to versandpakete table for UI visibility (#247)#248Avatarsia wants to merge 1 commit into
Avatarsia wants to merge 1 commit into
Conversation
Avatarsia
pushed a commit
to Avatarsia/OpenXE
that referenced
this pull request
Apr 9, 2026
All four are single-file Avatarsia-authored bug fixes that are also open upstream PRs on openxe-org: - fix/250-wiedervorlage-sidebar-counter (PR OpenXE-org#253) www/eproosystem.php +2/-2: reactivate Wiedervorlagen counter - fix/dateien-stichwoerter-245 (PR OpenXE-org#246) classes/Modules/Api/Controller/Version1/FileController.php +2/-2: fix variable scoping in POST /v1/dateien stichwoerter - fix/versandpakete-247 (PR OpenXE-org#248) classes/Modules/Api/Controller/Version1/TrackingNumberController.php +25: write tracking numbers into the versandpakete table so the UI shows them - fix/player-custom-module-support (PR OpenXE-org#256) phpwf/class.player.php +12/-2: support _custom.php extension files for page controllers, analogous to class.erpapi_custom.php Each branch is based on an older origin/master snapshot, but since origin/master is strictly behind upstream/master (zero divergent commits), git merges only the new commits during integration without re-applying the upstream drift.
Avatarsia
force-pushed
the
fix/versandpakete-247
branch
2 times, most recently
from
May 7, 2026 20:18
eeda701 to
91fb198
Compare
Contributor
Author
|
Force-Push-Hinweis: Branch wurde direkt auf Bestehende Inline-Kommentare auf alten SHAs erscheinen jetzt als „outdated" — gerne nochmal kommentieren auf den neuen Commits, falls noch was offen ist. |
Avatarsia
pushed a commit
to Avatarsia/OpenXE
that referenced
this pull request
May 20, 2026
All four are single-file Avatarsia-authored bug fixes that are also open upstream PRs on openxe-org: - fix/250-wiedervorlage-sidebar-counter (PR OpenXE-org#253) www/eproosystem.php +2/-2: reactivate Wiedervorlagen counter - fix/dateien-stichwoerter-245 (PR OpenXE-org#246) classes/Modules/Api/Controller/Version1/FileController.php +2/-2: fix variable scoping in POST /v1/dateien stichwoerter - fix/versandpakete-247 (PR OpenXE-org#248) classes/Modules/Api/Controller/Version1/TrackingNumberController.php +25: write tracking numbers into the versandpakete table so the UI shows them - fix/player-custom-module-support (PR OpenXE-org#256) phpwf/class.player.php +12/-2: support _custom.php extension files for page controllers, analogous to class.erpapi_custom.php Each branch is based on an older origin/master snapshot, but since origin/master is strictly behind upstream/master (zero divergent commits), git merges only the new commits during integration without re-applying the upstream drift.
…org#247) The API wrote tracking numbers only to the legacy 'versand' table, but the UI Pakete tab reads exclusively from 'versandpakete'. Now also inserts into versandpakete with lieferschein_ohne_pos link and sets lieferschein.versand_status = 1. Fixes: OpenXE-org#247
Avatarsia
force-pushed
the
fix/versandpakete-247
branch
from
May 20, 2026 10:10
91fb198 to
39e6585
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /v1/trackingnummern) now also writes to theversandpaketetablelieferschein.versand_status = 1so the Pakete tab shows the trackingProblem
The API wrote tracking numbers only to the legacy
versandtable, but the UI Pakete tab reads exclusively fromversandpakete. Tracking created via API was invisible in the UI.Root Cause
The old
versand-based display inlieferschein.phpwas replaced with the newversandpakete-based system, but the REST API was never updated to match.versandversandpaketeversand_statusChanges
classes/Modules/Api/Controller/Version1/TrackingNumberController.php:versandINSERT, also INSERT intoversandpaketewithlieferschein_ohne_poslinklieferschein.versand_status = 1Test plan
versandtable still gets the entry (backward compat)Fixes #247