Fix issue #8623 - Fix circular dependency in repositories - #8624
Merged
Merged
Conversation
* Move resetAllQueues to a service class * Add Repository wiring Unit test to prevent regressions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue:
Proposed changes:
This PR fixes the circular dependency introduced through the combined changes from d5f1f2d & afc8320 which in isolation worked fine but together created a circular dependency chain.
To fix this I moved the reason for the circularity, the
resetAllQueuesmethod from theStationPlaylistRepositoryinto a standalone service class.I've also added a unit test that does a simple instantiation of each repository to verify that we do not introduce circular dependencies again there. Since repositories are one of the most likely places for this to happen I think this should suffice for now.