Fix PR #180 review issues: decorator stacking, lazy loading, and docs… - #181
Merged
RyanTheRobothead merged 1 commit intoNov 17, 2025
Conversation
…trings Addresses all review comments on PR #180: 1. Fixed invalid @property/@classmethod decorator stacking (Comments #1 & #2) - Removed incompatible property/classmethod combinations - Replaced with proper @classmethod get_context() and set_context() methods - Maintains clean API while fixing Python decorator compatibility issues 2. Implemented true lazy loading to prevent --help arg capture - Changed _context from MadsciContext() to None as initial value - Context is now only created on first access via get_context() - This solves the original issue where module imports would capture CLI args 3. Fixed docstring formatting per PEP 257 (Comment #3) - Multi-line docstring with summary line - Blank line separator - Detailed description following PEP 257 standards 4. Updated all tests to use new classmethod API - All tests now call GlobalMadsciContext.get_context() - All tests now call GlobalMadsciContext.set_context() - Reduces verbose copy-modify-reassign patterns - All 7 tests pass successfully The changes maintain backward compatibility while implementing proper lazy initialization that solves the CLI argument capture issue.
RyanTheRobothead
deleted the
claude/review-pr-180-comments-0174zhzx93z2hASDDBBnZQVq
branch
December 27, 2025 15:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed invalid @property/@classmethod decorator stacking (Comments 1 & 2)
Implemented true lazy loading to prevent --help arg capture
Fixed docstring formatting per PEP 257 (Comment 3)
Updated all tests to use new classmethod API