Fix #191: Working Location Persistence and Writeback to Definition - #196
Merged
Conversation
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements location persistence functionality, ensuring that locations added via the API are written back to YAML definition files and persist across server restarts. The implementation includes a new _sync_locations_to_definition() method that synchronizes runtime locations from Redis to the definition file, preserving metadata like transfer capabilities and resource template information.
Key changes include:
- Adding a startup sync to write Redis-only locations to YAML during initialization
- Implementing automatic sync on location add, delete, and representation changes
- Comprehensive test coverage for persistence scenarios including add, update, delete, and startup sync
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
madsci/location_manager/location_server.py |
Implements _sync_locations_to_definition() method and calls it at startup and after location modifications to persist changes to YAML |
tests/test_location_persistence.py |
New test file with comprehensive tests for location persistence including add, update, delete, and startup sync scenarios |
tests/test_location_server.py |
Updates all test fixtures and functions to include tmp_path parameter for manager_definition configuration to support file-based persistence |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Info
Developer Checklists
I have: