Enhancement: Improved handling of disconnected nodes - #200
Merged
RyanTheRobothead merged 15 commits intoDec 15, 2025
Merged
Conversation
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
RyanTheRobothead
requested changes
Dec 12, 2025
RyanTheRobothead
left a comment
Member
There was a problem hiding this comment.
In addition to the in-line comments and suggestions:
- Please update the PR title to be a clear and concise description of the PR. Since this is used to generate release notes, it's important that the title clearly communicates the content.
- [nitpick] When referring to issue or PR's by number on GitHub in places like PR descriptions, one should prepend a
#in front of the number to automatically link to the relevant item, like#198-> #198 - For automated testing, I would recommend adding two test cases in
test_workcell_engine.py. You can patch the node client in the test to raise an exception, and validate that the node ends up properly marked as disconnected afterwards. For the second case, I would test that sending a reset correctly marks the node as initializing.
…erver.py Co-authored-by: Ryan D. Lewis <ryan.lewis@anl.gov>
Co-authored-by: Ryan D. Lewis <ryan.lewis@anl.gov>
… to lack of nodes
RyanTheRobothead
previously approved these changes
Dec 15, 2025
RyanTheRobothead
deleted the
198-enhancement-improved-handling-of-disconnected-nodes
branch
December 27, 2025 15:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Info
Addresses issue #198
Developer Checklists
I have: