Feature: Complete Event Manager Improvements - #219

Bumps ghcr.io/devcontainers-extra/features/ruff from 1.1.1 to 2.0.0.

---
updated-dependencies:
- dependency-name: ghcr.io/devcontainers-extra/features/ruff
  dependency-version: 2.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

…devcontainers-extra/features/ruff-2.0.0

Bump ghcr.io/devcontainers-extra/features/ruff from 1.1.1 to 2.0.0

Mark Phase 1 complete and note Phase 2 progress/remaining work.

Expose OTEL status in /health output and add OTEL settings to ManagerSettings to drive manager-level tracing configuration.

Add domain spans for workflow execution, per-step execution, and node action dispatch to improve end-to-end trace visibility.

Document WorkcellManager domain spans (workflow.execute/workflow.step/node.action) and update acceptance criteria notes.

Wrap datapoint ingestion in a data.save span and update Phase 2 progress notes.

Add domain spans for resource lifecycle/query endpoints and for location creation, resource attachments, and transfer planning.

Add diagnostic steps to help debug CI failures:
- Check service health endpoints before running tests
- Show docker compose status and lab_manager logs pre-test
- Show detailed service logs on test failure

Root cause: Docker Compose builds images in parallel, causing the
dashboard image to pull the old published base image from GHCR instead
of using the locally built one. This meant structlog and pytz were
missing.

Fixes:
- Build base madsci image first before docker compose up
- Add pytz to event_manager dependencies (was imported but not declared)
- Update pdm.lock with pytz dependency

Changes:
- e2e_tests now triggers after Docker Image workflow completes
- Pulls pre-built images from GHCR instead of rebuilding
- Adds docker workflow trigger for pull_request events
- Properly handles PR tags (pr-<number>) and branch tags
- Checkouts the correct commit for workflow_run events
- Adds manual trigger option to build locally if needed

Benefits:
- Faster e2e tests (no image rebuild)
- Ensures e2e tests use same images that will be published
- Prevents build order issues between base and dashboard images

Use github.head_ref (for PRs) or github.ref_name (for push) so that
both events for the same branch resolve to the same concurrency group.

Example: PR from 'feature-x' and push to 'feature-x' both get
group 'docker-feature-x', ensuring only one build runs.

Instead of using concurrency with cancel-in-progress (which causes
cancelled workflows to show as failed checks), simply limit push
triggers to main branch and tags.

- PRs trigger via pull_request event (covers all feature branches)
- Merges to main trigger via push event
- Tags trigger via push event

This eliminates duplicate runs without any cancelled/failed checks.

Documentation:
- Create docs/guides/logging.md combining logging guidelines and context
  migration guide into a single production-ready document
- Add Guides section to myst.yml table of contents
- Add example_lab/OBSERVABILITY.md to TOC (already existed)
- Remove docs/dev/ planning documents (19 files)

Code cleanup:
- Remove phase references from EventType comments
- Rename test_event_types_phase3.py to test_event_type_descriptions.py
- Update test docstring to remove phase reference

All valuable documentation from the planning docs has been extracted
into production docs. The OBSERVABILITY.md in example_lab already
contained the complete user guide for the OTEL stack.

…context

…ement

This commit introduces class and function decorators to simplify context
management across MADSci components:

## New Features

### Ownership Context Decorators (ownership.py)
- @with_ownership: Function decorator for ownership context
- @ownership_class: Class decorator that wraps all public methods
- get_ownership_overrides() method support for dynamic ownership

### OpenTelemetry Tracing Decorators (otel/tracing.py)
- span_context(): Context manager for creating spans
- @with_span: Function decorator for tracing
- @traced_class: Class decorator for automatic method tracing
- Utility functions: get_tracer(), get_current_span(), set_span_error(), etc.

### MadsciContext Decorators (context.py)
- @with_madsci_context: Function decorator for context management
- @madsci_context_class: Class decorator for automatic context wrapping

## Refactoring

### LocationManager
- Applied @ownership_class decorator
- Removed 10 manual `with ownership_context():` blocks

### WorkcellEngine
- Replaced manual tracer with span_context() from tracing module
- Removed self._tracer initialization

### ResourceManager
- Applied @ownership_class decorator with get_ownership_overrides()
- Removed _setup_ownership() method
- Removed HTTP middleware for ownership context

## Tests
- 91 new decorator tests (ownership, context, tracing, stacking)
- All existing tests pass (215 resource manager, 107 workcell, 101 location)

The ownership_class, madsci_context_class, with_event_client_class, and
traced_class decorators were wrapping class attributes that are types
(like DEFINITION_CLASS and SETTINGS_CLASS) as if they were instance
methods. This caused TypeError when trying to instantiate these classes.

The fix adds a check to skip attributes that are types (isinstance(attr, type))
in the _should_wrap_* functions for all four decorators:
- ownership.py: _should_wrap_ownership_method
- context.py: _should_wrap_madsci_context_method, _should_wrap_method
- otel/tracing.py: _should_wrap_traced_method

Comprehensively update READMEs, AGENTS.md files, and guides to document:

- EventClient context system for hierarchical logging
- Structured logging best practices (kwargs over f-strings)
- OpenTelemetry integration for distributed tracing
- Ownership context for metadata tracking
- Context decorators (@with_event_client, @event_client_class)

Updated files include:
- Root README.md and AGENTS.md with feature overview
- madsci_client README.md and AGENTS.md with EventClient patterns
- madsci_common README.md and AGENTS.md with context/OTEL docs
- madsci_event_manager README.md and AGENTS.md
- example_lab README.md with observability section
- docs/guides/logging.md with decorators and OTEL sections
- Regenerated API docs