Fix dashboard freeze on Show Copyable Workflow Step (#157) - #255
Merged
RyanTheRobothead merged 4 commits intoMar 27, 2026
Conversation
Adds :deep='2' and :showLength='true' to the vue-json-pretty component in the 'Show Copyable Workflow Step' section of NodeModal.vue. Without depth limiting, actions with deeply nested argument defaults (like run_assay) create an enormous DOM tree that freezes the browser. Fixes #157
Replace shared copy ref with per-action Record so toggling the copyable step for one action doesn't affect other action panels.
Replace manual string concatenation in set_text() with yaml.dump(), which was already imported but unused. Remove the now-dead cleanArgs() function and an erroneous stream/consumers import. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…d freeze The root cause of the dashboard freeze when clicking 'Show Copyable Workflow Step' was @VUE:updated lifecycle hooks on text fields (lines 97 and 127) calling set_text(action), which modifies reactive refs (json_text, text) mid-render. This triggered a re-render cascade that caused a stack overflow (RangeError: Maximum call stack size exceeded) with 8+ second hangs. Replace @VUE:updated with @update:modelValue so set_text() only runs when the user actually changes a value, not on every component re-render. This reduces render time from ~8500ms to ~14ms. Fixes #157 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Coverage report
This PR does not seem to contain any modification to coverable code. |
RyanTheRobothead
added a commit
that referenced
this pull request
Mar 31, 2026
- Complete CHANGELOG for v0.8.0 with all 9 merged PRs (#228, #235, #242, #255–#260), properly categorized under Added/Changed/Fixed - Fix broken ActionHandler import in module/basic and node/basic templates (replaced with @action decorator pattern) - Fix self.node_definition → self.node_info in 5 module templates (device, instrument, camera, liquid_handler, robot_arm) and their READMEs - Modernize self.logger.log() → self.event_client.info() in same 5 templates - Fix stale infrastructure references in example lab README (MongoDB→FerretDB, MinIO→SeaweedFS, wrong ports, deprecated /definition endpoint) - Update node module README to remove deprecated --node_definition reference Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@vue:updatedlifecycle hooks on text fields inNodeModal.vuecalledset_text(action)on every component re-render, not just user input. When the copyable section toggled, this created a re-render cascade causingRangeError: Maximum call stack size exceededand 8+ second hangs.@vue:updatedwith@update:modelValuesoset_text()only fires on actual value changes (14ms render, 0 errors):deep="2"depth limit tovue-json-pretty, scope copy toggle per-action, replace manual YAML string concatenation withjs-yamlTest plan
robotarm_1transfer action — renders in 14ms (was 8,551ms with stack overflow)yarn buildpasses (TypeScript + Vite)bmg_modulerun_assayaction (original reporter's scenario)Fixes #157
🤖 Generated with Claude Code