fix: CLI interactive mode respects --name arg; correct compose images - #292
Merged
Conversation
… images Two bug fixes: 1. `madsci new lab -n <name>` (and other `madsci new` subcommands) ignored the -n/--name argument when running in interactive mode (the default). The interactive prompt function now accepts an overrides dict so CLI-provided values are used as defaults for all 7 parameter types (string, integer, float, boolean, choice, multi_choice, path). 2. Generated Docker Compose templates used nonexistent local image names (e.g. `madsci-squid:latest`). Updated to use the correct GHCR images: `ghcr.io/ad-sdl/madsci_dashboard:latest` for lab_manager and `ghcr.io/ad-sdl/madsci:latest` for all other services. Also removed the stale `build:` section from lab_manager. Adds 10 regression tests covering overrides for every parameter type. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Coverage report
Click to see where and how coverage changed
The report is truncated to 25 files out of 55. To see the full report, please visit the workflow summary page. This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--name:madsci new lab -n my_lab(and all othermadsci newsubcommands) silently discarded the-n/--nameargument when running in interactive mode (the default).collect_parameters_interactive()now accepts anoverridesdict, andgenerate_from_template()passes CLI-provided names through it. All 7 parameter types (string, integer, float, boolean, choice, multi_choice, path) respect overrides.madsci-squid:latest,madsci-event-manager:latest). Updated to the actual GHCR images:ghcr.io/ad-sdl/madsci_dashboard:latestfor lab_manager,ghcr.io/ad-sdl/madsci:latestfor all other services. Removed stalebuild:section from lab_manager. Fixed in bothstandardanddistributedlab templates.Test plan
collect_parameters_interactiveoverrides (one per parameter type + defaults + isolation)madsci new lab -n my_custom_labcreates correctly-named output directorytest_new.pypass🤖 Generated with Claude Code