Fix for Issue #211: Workflow get_datapoint_id ignores nonexistent label for single datapoint steps. - #357
Open
AileenCleary wants to merge 6 commits into
Open
Fix for Issue #211: Workflow get_datapoint_id ignores nonexistent label for single datapoint steps.#357AileenCleary wants to merge 6 commits into
AileenCleary wants to merge 6 commits into
Conversation
…el for single datapoint steps.
…errors are fixed in a different PR and will pass with it merged.
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
tginsbu1
previously approved these changes
Aug 13, 2026
tginsbu1
left a comment
Contributor
There was a problem hiding this comment.
Seems like a reasonable way to handle it, I approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Info
Fix for Issue #211
Previously, if a step had only one datapoint, there was no check against nonexistent labels. Moved logic around to check label existence for single and multiple datapoint steps at the same time, and throw a
ValueErrorif nonexistent.Added to unit tests to ensure an error is thrown for nonexistent labels on single datapoint steps.
Developer Checklists
I have: