Repository navigation
refactor(reporting): drop the dead legacy budget-breakdown panel renderer - #114
Merged
Merged
Conversation
…erer _render_breakdown_sections and _breakdown_panel have no callers: the run report renders breakdowns through the presentation pipeline (presentation.adapters.build_run_presentation + blocks). The dead panel predates the bake-time attribution fix, so reviving it would resurface the misleading sampling residual row. Shared gauge/over-budget helpers stay — they back the test-covered standalone wrappers.
This was referenced Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_render_breakdown_sectionsand_breakdown_panelinsrc/whestbench/reporting.pyhave no callers anywhere insrc/ortests/:render_human_report/render_human_resultsbuild run reports through the presentation pipeline (presentation.adapters.build_run_presentation+presentation.blocks), which fully replaced this panel.Beyond being dead weight, the legacy panel still renders the sampling breakdown the pre-#113 way — an unattributed
Residual Wall Timerow summing bake-machine wall clock (discourse #18093) — so any future revival would silently resurface that bug. Deleting it closes that door.Kept:
_gauge_renderable,_over_budget_renderable,_compute_gauge_state,_label_with_code,_fmt_flops,_as_float— all have live callers (the test-covered standalone wrappers_render_budget_gauge/_render_over_budget_paneland other report sections). The two docstrings that referenced_breakdown_panelnow point at the presentation pipeline.Net: 1 file, +4/−118.
Verification
grepacrosssrc/andtests/: zero remaining references to either function.ruff check/ruff format --check/pyrightclean; full suite 1128 passed locally.Follow-up to #113.