Skip to content

Fix Clock. Tooltip calendar text overflows(#2240) - #3255

Merged
Alexays merged 1 commit into
Alexays:masterfrom
LukashonakV:ISSUE#2240
May 28, 2024
Merged

Fix Clock. Tooltip calendar text overflows(#2240)#3255
Alexays merged 1 commit into
Alexays:masterfrom
LukashonakV:ISSUE#2240

Conversation

@LukashonakV

@LukashonakV LukashonakV commented May 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hi @Alexays, @FilippoBonazziSUSE this MR solves #2240
Actually here it's GtkLabel wrong behavior with tooltips. Even @BrianCArnold has found workaround it's better to have code fixed.
Temporary for now I replaced clock label with Gtk::TextView. In order to have the same styling as it was for tooltips in the system, users should use next css styling

textview#clock.tooltip, textview#clock.tooltip text {
   background-color: inherit;
   padding: inherit;
}

For now I'm trying to write test case in pure C in order to provide it gtk maintainers to fix gtk

So fixed variant looks good
ps_2024-05-11-01_06_12

@LukashonakV LukashonakV changed the title Clock. Tooltip textview Clock. Tooltip calendar text overflows(#2240) May 10, 2024
@LukashonakV

LukashonakV commented May 15, 2024

Copy link
Copy Markdown
Contributor Author

Hi @Alexays , ping )

@LukashonakV
ISSUE#2240. Clock Gtk::Label as a calendar tooltip
b288fdf 
Signed-off-by: Viktar Lukashonak <myxabeer@gmail.com>
@LukashonakV

LukashonakV commented May 17, 2024

Copy link
Copy Markdown
Contributor Author

Hi @Alexays , finally this MR is ready to merge. According discussion here Label set_markup tooltips width for the Widget class is limited.
So for now I found the better solution using one more Gtk::Label as a tooltip for the base Clock label. And then to set_markup for this tooltip label. Such approach allows solve #2240 without any additional CSS style customization from the user

@LukashonakV LukashonakV mentioned this pull request May 17, 2024
Closed
@LukashonakV

LukashonakV commented May 18, 2024

Copy link
Copy Markdown
Contributor Author

Hi @Alexays , ping

@LukashonakV

LukashonakV commented May 20, 2024

Copy link
Copy Markdown
Contributor Author

Hi @Alexays , ping once again )

@LukashonakV

LukashonakV commented May 22, 2024

Copy link
Copy Markdown
Contributor Author

Hi @Alexays , any feedback ?

@LukashonakV

LukashonakV commented May 23, 2024

Copy link
Copy Markdown
Contributor Author

Hi @Alexays , ping again

@alkar

alkar commented May 23, 2024

Copy link
Copy Markdown

Amazing, thanks for this PR!

@LukashonakV

LukashonakV commented May 23, 2024

Copy link
Copy Markdown
Contributor Author

@Alexays any feedback?

@LukashonakV LukashonakV changed the title Clock. Tooltip calendar text overflows(#2240) Fix Clock. Tooltip calendar text overflows(#2240) May 24, 2024
@LukashonakV

LukashonakV commented May 24, 2024

Copy link
Copy Markdown
Contributor Author

@Alexays ?

@FilippoBonazziSUSE

FilippoBonazziSUSE commented May 24, 2024

Copy link
Copy Markdown

It looks like Alexays is unavailable right now (travelling, on vacation, ...). I'm sure he will see your pings once he is available again. I don't think pinging him every few hours helps.

@Alexays

Alexays commented May 28, 2024

Copy link
Copy Markdown
Owner

LGTM, and yes i was on vacation :)

@Alexays
Alexays merged commit d4413f5 into Alexays:master May 28, 2024
@FilippoBonazziSUSE

FilippoBonazziSUSE commented May 28, 2024

Copy link
Copy Markdown

Thanks @LukashonakV for providing the fix, can't wait to try it out.

@LukashonakV
LukashonakV deleted the ISSUE#2240 branch May 28, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LukashonakV @alkar @FilippoBonazziSUSE @Alexays