flake: fix overlay not actually being applied - #3208
Merged
Merged
Conversation
Contributor
|
Thanks, apologies to @Arjun31415 and others. This PR is crucial to merge (I was almost about to PR), because I made a mistake (again!) and this commit is borked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3196 made some changes to
flake.nix. In this line flake'swaybarpackage was defined to be the one innixpkgsbecause the function that was passed togenSystemsargument was called withnixpkgswithout the flake's overlay applied. I changed thegenSystemsfunction to passnixpkgsthat uses the flake's overlay so the package comes from the flake itself and notnixpkgs.