Make battery module update on plugging/unplugging again (refs #2519) - #3474
Merged
Merged
Conversation
Historically we listened to /sys/class/poewr_supply inotify events, which does not seem to work anymore. We switched now to udev netlink kernel events.
schmop
force-pushed
the
battery-plugging-instant-updates
branch
from
July 26, 2024 23:19
a519c0c to
f4608b3
Compare
Contributor
Author
|
So it seems, that the udev kernel events are sent very early. The battery status "Charging" might return just a bit later from the When implementing some |
Alexays
force-pushed
the
master
branch
2 times, most recently
from
September 13, 2024 07:40
d623a89 to
a4d31ab
Compare
Contributor
Author
|
Hi, this looks awesome. @Alexays would you consider accepting this PR? |
Owner
|
LGTM. |
Owner
|
Reverted, FreeBSD is failing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When switching how you listen for battery plugging status events, the battery status will instantly update again!
Instead of inotify events on the /sys/class/.../ files, it is recommended to listen to udev netlink kernel events.
Closes #2444
Closes #2519
I need aid implementing this, because I'm new to this project.
I will try to make this code look more like the backlight_backend, which also uses the udev netlink interfaces.