nix: remove patches from downstream - #3640
Merged
Merged
Conversation
The patches is the modification of downstream, it should not affect upstream. Any changes of upstream would caused patch fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested by adding it to my NixOS config.
The
patchesare modifications from downstream and should not affect upstream. Any changes to upstream would cause the patch to fail.There are few people maintaining Nix here, I guess, since the conflict has existed for 1 week (since the last flake.lock update). So, I keep using overrideAttrs from nixpkgs in order to reduce the need for maintenance.
Close #3639.