Skip to content

#2275 Backlight: Add minimum brightness - #3637

Merged
Alexays merged 3 commits into
Alexays:masterfrom
TripleTrable:backlight/add_min_brightness
Sep 30, 2024
Merged

Alexays merged 3 commits into
Alexays:masterfrom
TripleTrable:backlight/add_min_brightness

Conversation

@TripleTrable

Copy link
Copy Markdown
Contributor

As currently it is possible to turn the brightness to zero which may not be desirable, this patch add a configurable brightness check.

As currently it is possible to turn the brightness to zero which may not
be desirable, this patch add a configurable brightness check.
@Alexays

Alexays commented Sep 25, 2024

Copy link
Copy Markdown
Owner

Default should still be zero to avoid breaking change

@LukashonakV

LukashonakV commented Sep 25, 2024

Copy link
Copy Markdown
Contributor

Default should still be zero to avoid breaking change

In such case @TripleTrable you should assign 0.0

@TripleTrable

Copy link
Copy Markdown
Contributor Author

I'll work on it once im back from Work

@TripleTrable

Copy link
Copy Markdown
Contributor Author

Done. Any other requested changed?

@Alexays
Alexays merged commit e7b2d33 into Alexays:master Sep 30, 2024
@Alexays

Alexays commented Sep 30, 2024

Copy link
Copy Markdown
Owner

LGTM thx :)

@TripleTrable
TripleTrable deleted the backlight/add_min_brightness branch November 20, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants