Issue 3981: try and fix memory leak in privacy module - #4092
Merged
Merged
Conversation
|
Apparently you forgot to apply the clang-format to the file. |
Contributor
Author
|
That's not correct. I did run it on the file, I even still have it in history. 😛 I just didn't run it on everything else, which has been broken for a while. If you check the details of the failed check, it failed for src/modules/sway/workspaces.cpp, which I haven't edited here. |
RobertMueller2
marked this pull request as draft
May 3, 2025 07:26
RobertMueller2
marked this pull request as ready for review
May 3, 2025 09:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3981
As I'm mostly dealing with languages with automatic memory management, I'm not an expert on this. :p But I think
update_tooltipcreates objects with every update and at least doesn't get rid of the childrens' children.Attempt to address this by using
make_managedinstead of new objects.I've tested it and at least with my limited test it worked, can't see the reported memory leak with heaptrack anymore, either.