Fix: styling: set gamemode icon size and spacing to 0 if use-icon is false - #4448
Conversation
ninetailedtori
left a comment
There was a problem hiding this comment.
This change will work fine, and as a patch that will function more than well enough, this could in fact be how we handle use-icon behaviour for every module in the project. However there may be a technically "better" way of writing this, adding the check in the label format section instead. See l221 in .../gamemode.cpp, l226 in the changes.
|
Title of this one should be corrected to specify "gamemode icon size and spacing", unless this will expand to all modules. |
That is a more elegant solution, I can revert/change to that instead? It seems to work the same on my system (tbh why wouldn't it) |
|
Could you upload it to a separate branch in your fork and link it here? Then we can decide if to force push to this PR, perhaps :] |
|
https://github.com/winkelnp/waybar/tree/gamemode-icon-alt Realised a smidge late that that branch is technically built off |
|
Yes, that works well, as a format-based check! I recommend checkout to gamemode-icon, resetting the HEAD on your local gamemode-icon branch to master, then rewriting the changes on the branch in a single commit, because the other branch as you've said includes a commit then the commit that reverts it then adds a separate commit, which is a little messy :] You can force push the single format commit after, and I'll re-approve! ❤️ |
c52a391 to
e87ece4
Compare
ninetailedtori
left a comment
There was a problem hiding this comment.
Lovely, and perfectly functional. Approved :)
Fixes #2206
Quite a simple solution, might be a bit crude, is there a better way to do this?