Skip to content

Conversation

@asmaloney
Copy link
Contributor

There are no tests to run, so it's just noise in the PRs.

(Based on discussion in #613.)

@gucio321
Copy link
Collaborator

maybe just disable the PR comments?
This will break badge in readme...

There are no tests to run, so it's just noise in the PRs.
@asmaloney
Copy link
Contributor Author

But if it isn't running any tests, why is it even running at all?

(Removed badge in README.)

@gucio321
Copy link
Collaborator

but there is a few tests, it is just ~2% 😄

@asmaloney
Copy link
Contributor Author

OK 😆

I don't see any point in running codecov for this project since (1) it's not the type of project where you can get high code coverage (2) it's just noise in PRs, and (3) it just wastes resources & takes extra time for no benefit at all.

I guess you/@AllenDang can just close this PR if you/he want to keep codecov around for some reason!

@gucio321
Copy link
Collaborator

I guess you/@AllenDang can just close this PR if you/he want to keep codecov around for some reason!

sadly, I don't have such a power 😄
we need to let @AllenDang to decide here ;-)

@AllenDang AllenDang merged commit 66e8a00 into AllenDang:master Nov 30, 2022
@asmaloney asmaloney deleted the ci-remove-codecov branch November 30, 2022 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants