Conversation
|
|
||
| ## Your Task | ||
|
|
||
| 1. Run `git diff HEAD~5..HEAD --name-only` to identify files changed in recent commits. |
There was a problem hiding this comment.
this looks incorrect command, we want to review the work on the branch since the upstream target/main branch
There was a problem hiding this comment.
Still hardcodes origin/main. Pipeline already has base var. Mismatch on non-main targets. Pass BASE into build_simplify_prompt, template origin/{BASE}...HEAD.
| - Nested ternary operators (replace with if/else chains) | ||
| - Unnecessary comments that describe what the code obviously does | ||
| - Magic values that could use a nearby named constant | ||
| - Dead code branches that can never execute |
There was a problem hiding this comment.
We should also add instructions to:
- Detect boilerplates in the existing changeset and reduce them by using existing helpers
- Prefer reusing existing helpers
- Prefer adding additional parameters to existing helpers if needed rather than created duplicate helpers
There was a problem hiding this comment.
Addressed. Prompt now detects boilerplate. Prefers reusing existing helpers. Prefers extending helpers over new duplicates.
| - Magic values that could use a nearby named constant | ||
| - Dead code branches that can never execute | ||
| 3. Apply **readability-only fixes** — each change must make code clearer without altering structure. | ||
| 4. Do NOT: move code, change function signatures, extract new helpers, restructure control flow. |
There was a problem hiding this comment.
Let's remove than point -4- which is in contraction with the previous comment
There was a problem hiding this comment.
Point 4 still present in reviewed diff (line 20). Remove if not already dropped in a later push.
| failure_label="Simplify step skipped", | ||
| actions_log=actions_log, | ||
| use_skill=True, | ||
| ) |
There was a problem hiding this comment.
If any changes is performed we need to amend to the HEAD commit if branch has a single commit otherwise if the branch has multiple commits let's add a refactor commit for the changes
There was a problem hiding this comment.
Implemented. Step 6 counts commits via git rev-list. Single commit amends HEAD. Multiple commits add refactor commit. Multi-commit path untested — flagged.
|
@Koan-Bot rebase view comments and adjust |
015ddec to
69d933c
Compare
Rebase: feat: add post-review simplify pass to /pr pipelineBranch Diff: 4 files changed, 160 insertions(+), 15 deletions(-) Review feedback was analyzed and applied. Actions
CICI failed initially, fixed on attempt 1. Automated by Kōan |
|
@atoomic is it normal that your personal skills are in the Git history? Other than that, this PR looks great. |
|
@Koan-Bot rebase |
|
Let's make sure nothing is referencing private skills like |
Rebase with requested adjustmentsBranch Changes applied
StatsActions performed
CI statusCI will be checked asynchronously. Automated by Kōan |
cbfad61 to
e82fb53
Compare
|
|
|
@Koan-Bot rebase |
e82fb53 to
766f3d2
Compare
Rebase completed; review feedback not appliedBranch Warning Review feedback was NOT applied — the feedback step errored. The reviewer comments above still need to be addressed: re-run StatsActions performed
CI statusCI will be checked asynchronously. Automated by Kōan |
Rebase completed; review feedback not appliedBranch Warning Review feedback was NOT applied — the feedback step errored. The reviewer comments above still need to be addressed: re-run StatsActions performed
CI statusCI will be checked asynchronously. Automated by Kōan |
|
@Koan-Bot rebase |
… simplify pass, drop point 4
766f3d2 to
b44f03e
Compare
Rebase with requested adjustmentsBranch Changes applied
StatsActions performed
CI statusCI will be checked asynchronously. Automated by Kōan |
|
@Koan-Bot recreate |
Recreated: feat: add post-review simplify pass to /pr pipelineBranch Branch Diff: 5 files changed, 200 insertions(+), 15 deletions(-) Tests: 4 failed, 403 Actions
Automated by Skuggi |
…ss to /pr pipeline
b44f03e to
7c96a55
Compare
Confirmed. Tracked files use |
|
|
Rebase with requested adjustmentsBranch Changes applied
Not changed (and why)
StatsActions performed
CI statusCI will be checked asynchronously. Automated by Skuggi |
…ss to /pr pipeline
7c96a55 to
3722008
Compare
|
@Koan-Bot squash and rebase |
3722008 to
3a1d555
Compare
Squash: 2 commits → 1Branch Commit messageActions
Automated by Skuggi |
PR Review — Add post-review simplify pass to /pr pipelineAdds a readability-only simplify step to the /pr pipeline that amends into a single-commit branch or lands a new refactor commit otherwise, gated on the refactor skill being present.
✅ Resolved since last review (2)Previously-flagged issues verified fixed
🟢 Suggestions
1. Diff-range hardcodes `origin`, but the pipeline may rebase onto a different remote
|
Adds readability-only simplify step (step 6) to /pr pipeline after quality review. Enhances atoomic.refactor skill with --simplify mode constraining changes to clarity improvements only (rename for clarity, flatten nested ternaries, remove dead branches, prune obvious comments — no structural changes). Fixes Anantys-oss#734
3a1d555 to
5ae8ea3
Compare
Rebase with requested adjustmentsBranch Changes applied
Not changed (and why)
StatsActions performed
CI statusCI will be checked asynchronously. Automated by Skuggi |
Adds step 6 simplify pass to /pr pipeline for readability improvements after quality
review. Enhances atoomic.refactor skill with --simplify mode (clarity only, no
structural changes). New prompt template
pr-simplify.mdguides the simplify pass.Tests: 10089 passed, all green.
Fixes #734