fix: set dismissable={false} on ValidationQueue and NoteEdit dialogs - #418
Open
AliMahmoudDev wants to merge 1 commit into
Open
AliMahmoudDev wants to merge 1 commit into
AliMahmoudDev wants to merge 1 commit into
Conversation
- SimilarityDialog (used by ValidationQueue) now has dismissable={false}
to prevent accidental dismissal when tapping outside the dialog
- NoteEditDialog now has dismissable={false} to prevent losing
unsaved note edits and to block background interaction
Fixes AntoC-dev#302
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #302
Problem
Two related modal issues:
ValidationQueueand related dialogs close when the user taps outside — they should stay open throughout the validation flowSolution
dismissable={false}on theSimilarityDialog(used byValidationQueue) to prevent accidental dismissal when tapping outside the dialogdismissable={false}on theNoteEditDialogto prevent losing unsaved note edits and to block background interactionThe
dismissableprop on React Native PaperDialogcomponents controls whether the dialog can be closed by tapping outside. Setting it tofalseensures these important dialogs stay open until the user explicitly chooses an action.Files Changed
src/components/dialogs/SimilarityDialog.tsx— addeddismissable={false}src/components/dialogs/NoteEditDialog.tsx— addeddismissable={false}Closes #302