Repository navigation
fix(claude-agent-sdk): keep the assistant model when result model_usage covers the session - #4036
Open
Harsh23Kashyap wants to merge 2 commits into
Open
Harsh23Kashyap wants to merge 2 commits into
Harsh23Kashyap wants to merge 2 commits into
Conversation
|
Legend! Thanks for fixing! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
description
felixnic pointed out on #3949 that after
set_model()mid-session,llm.model_namecan still show the first model. i checked it with realAssistantMessage/ResultMessagetypes and it reproduces.set_model("haiku"), turn 2 runs on haikumodel_usagecovers the whole session, so it lists both modelsfix:
model_usageis not used to replace itmodel_usageis still used as before, so the multi-model pick from [bug][claude-agent-sdk] _extract_model_name_from_usage returns first dict key, mis-attributes multi-model runs #3136 is unchangedbefore and after, same script:
tests:
test_wrappers_unit.py, the first one fails on main and passes with the fixpytest testsin the package: 54 passedseparate from #3949, which only touches the per-turn token counts.
checklist: