Repository navigation
Fix for try_stream_replace_all in README - #167
Open
kaleidawave wants to merge 1 commit into
Open
kaleidawave wants to merge 1 commit into
kaleidawave wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying this out and noticed that the reference to
try_stream_replace_allin the README was missing thetry_and so was incorrect. I also noticed that the block had theignoremodifier on it and so was not getting run or compiled as a test.This PR fixes the documentation and removed the
ignoreso that should not happen in the future.I notice this crate is using the
doc_commentcrate and has a large multiline comment at the start of thelib.rs. I am wondering whether it would be a good separate change to remove this and use the#[doc = include_str!("../README.md")]feature which has been added since the creation of this crate?