Translations#1606
Open
kshitijk4poor wants to merge 64 commits into
Open
Conversation
- Added `strict_mode` parameter to `_install_translations_and_print_path` to control behavior on missing translations. - Implemented lenient mode to allow report export with missing translations, generating a `missing_translations.po` file. - Updated `export` and `export_cli` functions to support the new `--lenient-translations` flag. - Added unit tests for strict and lenient translation modes, ensuring proper handling of missing translations.
- Introduced a threading lock to ensure safe access to the `missing_translations` set across multiple instances. - Updated methods in `TranslationCollectMissingException` to use the lock when adding missing translations and retrieving the set. - Ensured that the `get_missing_translations` and `clear_missing_translations` methods are thread-safe to prevent concurrent modification issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, when exporting reports in non-English languages, the process crashes on the first missing translation. This makes it difficult to develop and maintain translations as you can't see all missing translations at once. This PR aims to fix problem #1445
Solution
Implemented a flexible translation handling system that:
--strict-translations)Implementation Details
TranslationCollectMissingExceptionclass that collects missing translations and returns the original textstrict_mode=Truetostrict_mode=False--strict-translations/--lenient-translationsCLI flag (with lenient as the default)missing_translations.pofile with all missing translationsBenefits
--strict-translationsBackward Compatibility
--strict-translationsflagTODO
TranslationCollectMissingException.gettext()- use more specific exception types instead of genericExceptionmissing_translationsclass variable to handle concurrent access