Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a Smart Zoom (
smartZoom) action to the Navigation category (categoryNavigation) in mouse button bindings, allowing users to map a mouse button to trigger macOS's native smart zoom gesture (equivalent to a two-finger double-tap on Magic Mouse or Trackpad).Changes
SystemShortcut.swift:smartZoomwith pseudo-code0xFFFB, modifier0, execution mode.trigger, and SF Symbolplus.magnifyingglass.smartZoomtocategoryNavigation.< 0xFFFCto< 0xFFFB.ShortcutExecutor.swift:executeSmartZoom()that posts a synthetic macOS gesture event (NSEventTypeGesture= 29,kIOHIDEventTypeZoomToggle= 22) marked withMosEventMarker.syntheticCustom.smartZoom.Localizable.xcstrings:InputProcessorTests.swift:Verification
scripts/qa/lint-logi-boundary.shsmartZoominInputProcessorTests