Conversation
CalebFenton
requested changes
Apr 16, 2019
| mkdir ~/bin || cd ~/bin | ||
| curl --location -O https://bitbucket.org/JesusFreke/smali/downloads/smali-2.2.5.jar && mv smali-*.jar smali.jar | ||
| curl --location -O https://bitbucket.org/JesusFreke/smali/downloads/baksmali-2.2.5.jar && mv baksmali-*.jar baksmali.jar | ||
| mkdir ~/bin && cd ~/bin || cd ~/bin |
Owner
There was a problem hiding this comment.
Why run this command twice? And why only run that command if mkdir creates a new directory? The code previously reads "attempt to create directory and then, regardless of what happens, change directory into ~/bin", but now it reads "create directory and if successful change directory to ~/bin and then change directory to ~/bin"
| curl --location -O https://bitbucket.org/JesusFreke/smali/downloads/baksmali-2.2.5.jar && mv baksmali-*.jar baksmali.jar | ||
| mkdir ~/bin && cd ~/bin || cd ~/bin | ||
| curl --location -O https://bitbucket.org/JesusFreke/smali/downloads/smali-2.2.6.jar && mv smali-*.jar smali.jar | ||
| curl --location -O https://bitbucket.org/JesusFreke/smali/downloads/baksmali-2.2.6.jar && mv baksmali-*.jar baksmali.jar |
Owner
There was a problem hiding this comment.
This is a good direction, but I can't accept this PR with the other change. Also, the newest version is 2.2.7 now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.