Repository navigation
Review fixes: change safety, IPv6 renumbering per WAN, RFC 9096 lifetimes, durable state - #96
Merged
Merged
Conversation
…imes, durable state - apply survives a dropped SSH session (signals shielded); an interrupted apply can be rolled back; confirm / timer / revert / rollback share one lock; snapshots are written durably and never overwrite each other; a rollback keeps the current web UI password; two web applies at once are serialised; a dead apply job no longer blocks the web UI; unknown changes are high risk - state files: private temp file + fsync before rename; one doctor heal at a time - stale LAN prefixes are recorded and judged per delegating WAN, and only once that WAN's prefix is back on the bridge (no more deprecating the same prefix after every reboot) - RA prefix lifetimes within RFC 9096 (lease default and ceiling 45m, ra_interval at most 900 s) - a DHCP / static WAN without mtu puts its port back to 1500 after PPPoE baby jumbo frames - fallback: drop only catches IPv6 traffic the policy routes (other prefixes use the default WAN) - MGLRU min_ttl_ms at every boot; S3 prefix as a directory; archive secret names; auto_heal needs a channel; a WebDAV password may contain spaces - CI: the IPv6 dual-prefix check retries (flaked once on a GitHub runner) Claude-Session: https://claude.ai/code/session_01HWeUjo1dmS7gBkCYHrVjCr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A second review of the earlier P0 / change-safety / network / sys work (#9 #10 #11 #12 #17 #22 #38 #21 #35 #36 #39 #46 #8 #5 #7 #16 #20) found and fixed these:
mr apply --confirmno longer dies halfway when the SSH session drops (the confirm window never started); an apply killed by OOM can be rolled back instead of blocking every later change; confirm / timer / web revert / rollback are serialised by one lock; snapshots are written durably and get unique names; a rollback keeps the current web UI password; two web applies at once cannot both start; a dead apply job no longer answers 409 forever; an apply without a record of the last config counts as high risk.ra_interval≤ 900 s, since dnsmasq keeps lifetimes ≥ 3 × interval).fallback: dropdropped IPv6 from another WAN's prefix; it now matches the policy's ownip6 saddr @pd6_N.writeAtomicused a shared temp name and no fsync; onedoctor --healat a time.min_ttl_mswithout zram too; S3 prefix handled as a directory; archive secret names known to the UI;auto_healrequires a channel; WebDAV passwords may contain spaces.Why
The earlier implementations were reviewed again at the owner's request; each change fixes a concrete failure scenario and comes with a regression test.
Verification
tools/ci.sh: ALL CHECKS PASSED (new tests: TestApplyShieldsSignals, TestRollbackInterruptedApply, TestConfirmRevertRace, TestRestoreKeepsPassword, TestApplyJobStartSerialized, TestRiskUnknownChangesIsHigh, TestDeadApplyJobIsFailed, TestSnapshotNames, TestWriteAtomicConcurrent, TestLan6PlanWaitsForPrefix, TestLan6PlanPerWAN, TestWANLinkMTUAfterPPPoE, TestRALeaseCap, TestMGLRUMinTTLAlways, RA capture with the real dnsmasq).build/m3/selftest.shpassed (sysupgrade A–E, preinit P1–P8 incl. a power cut inside the confirm window).sync-public.py: no leaks.https://claude.ai/code/session_01HWeUjo1dmS7gBkCYHrVjCr