Repository navigation
net: WAN without IPv6 takes no RAs; webui: WAN removal takes its references along - #128
Merged
Merged
Conversation
…s IPv6 removes the settings that reference it - network.sh: a WAN link device that no IPv6-enabled DHCP / static WAN uses gets accept_ra 0 and loses leftover global IPv6 addresses and RA routes (ipv6: false used to keep accept_ra=2, the SLAAC address and the RA default). - web UI: deleting a WAN, or turning its ipv6 / ipv6_pd off, lists the policy routes, multiwan weights / dial order, multicast upstream, WAN-limited firewall rules, DDNS sources and reconnect schedules that name it and removes them after confirmation; saving used to fail validation. Closes #126 Closes #127
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
mod_net_render.go:network.shsetsaccept_ra=0on every WAN link device that no IPv6-enabled DHCP / static WAN uses, and flushes leftover global IPv6 addresses and RA routes there. Test:TestWANIPv6OffClearsRA.ui/net.js: deleting a WAN, or turning itsipv6/ipv6_pdoff, lists the settings that reference it (policy routes; multiwan weights and dial order; multicast upstream; firewall rules limited to that WAN; DDNS sources; reconnect schedules — for IPv6 only thenat6policies) and removes them after confirmation. A firewall rule limited to that WAN alone is removed, not widened to all WANs; a dial order left with one WAN is cleared.Why
ipv6: falsea DHCP WAN keptaccept_ra=2, its SLAAC address (dhcpcdpersistent) and the RA default route, so IPv6 could not be turned off.policy_routes[0].via: unknown wan "wan2"), and nothing told the user what else to remove.Verification
sudo ./tools/ci.sh: ALL CHECKS PASSED (new Go test, i18n check with the added strings).wanRefsexercised with node against a multi-dial config: deleting wan2 lists and removes its policy route, weight, dial order, a wan2-only open port and a reconnect schedule; turning wan's IPv6 off lists only the nat6 policy.Closes #126
Closes #127