Repository navigation
net: clean stale state after WAN protocol switches - #141
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
mini-routerlink alias; preserve unmarked user or legacy interfaces.ethtooloutput and preserve the original link UP/DOWN state.ethtoolto installer/factory packages, fix the net documentation table, and add regression tests for real hook/apply paths and cleanup edge cases.Why
Switching a WAN from PPPoE to DHCP/static could delete the new WAN lease, routes, and DNS state. Removed IPv6 PD prefixes could remain advertised, while VLAN interfaces and cloned MACs survived configuration changes. Runtime dhcpcd hooks during a protocol switch also must not overwrite the old prefix owner before the apply is committed.
Verification
gofmt -l .go vet ./...go test -count=1 ./...sh tools/ci.sh—ALL CHECKS PASSEDorigin/mainsh tools/ci.sh— passedCloses #140