Repository navigation
apply: services the config does not run are not restarted — install.sh no longer rolls back on machines without WiFi - #143
Merged
Conversation
…h no longer rolls back on machines without WiFi (Closes #142) plan() restarted the service of every changed generated file. On the first apply wifi-post.sh is new, so mr-hostapd was restarted on boxes without a radio, refused to start and rolled back install.sh step 5 on every VM and WiFi-less x86 box. A managed service the config does not enable is now only disabled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 17, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
mr/apply.goplan(): a service that mr manages but the config does not enable (managedServicesminusenabledServices) is no longer put on the restart list when one of its generated files changes; the plan disables it instead, as before. Test:TestPlanDoesNotRestartServicesTheConfigDoesNotRun(with radios a new hostapd config still restartsmr-hostapd; without radioswifi-post.shis still written butmr-hostapdis not restarted).Why
On a fresh Alpine machine without WiFi (any VM, most x86 boxes)
install.shstep 5 always failed and rolled back: the first apply writes/etc/mini-router/gen/wifi-post.sh, which maps tomr-hostapd, somr-hostapdwas restarted althoughwifi.radios: []does not run it; itsstart_prerefuses ("no hostapd config for an existing radio") and the whole apply was rolled back. Such a box could never be applied, byinstall.shor a latermr apply. The AX6000 image always has radios, which is why this did not show up there.Verification
sudo ./tools/ci.sh: ALL CHECKS PASSED. The new test fails without theapply.gochange.install.shwithMR_LOCALfrom this branch'stools/release.sh:main(7b5c03e), DHCP WAN: step 5 rolls back with the error above (3/3).applied; a LAN client gets a lease, resolves names, reaches the internet and gets HTTP 200 from the panel;GET ?a=statusworks after login.applied; the LAN client gets IPv4 and a global IPv6 address from the delegated /60 and pings the ISP's IPv6 address.risk/verify/rollback unchanged.The installer itself is not touched (no overlap with #139).
Closes #142
🤖 Generated with Claude Code