Repository navigation
install: PPPoE checks that the kernel can do PPPoE first — a clear error instead of a rollback after 90 s - #148
Merged
Merged
Conversation
…ror instead of a rollback after 90 s (Closes #146) Alpine's linux-virt kernel (cloud images, many VMs) is built without CONFIG_PPPOE. install.sh with MR_WAN_PROTO=pppoe used to write the config, wait 90 s for a session that can never come up and roll back ("PPPoE did not come up within 90s"). Now: - install.sh loads pppoe when PPPoE is chosen and stops with the fix (apk add linux-lts, reboot) when /proc/net/pppoe does not appear; - mr-pppoe's start_pre fails with the same reason (also to syslog), so an apply rolls back at once and says why; - mr doctor: a PPPoE WAN that is down without /proc/net/pppoe names the kernel, not the cable. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Cd1s
added a commit
that referenced
this pull request
Oct 17, 2026
…s with simulated ISPs (DHCP, PPPoE, DHCPv6-PD) and a LAN client (#149) * tools/lab: add isolated fresh environment harness * tools/lab: record A1 verification results * tools/lab: keep veth pairs inside lab namespaces * tools/lab: isolate LAN and add guest seed installation * tools/lab: add ISP slirp PPPoE hooks and live scenarios * tools/lab: record leakage and ISP milestones * tools/lab: complete cloud-init guest handoff and fallback LAN services * tools/lab: fix cloud-init seed YAML and document guest limits * tools/lab: update A1 continuation report * tools/lab: seed Alpine router package layer for offline install * tools/lab: protect host resolver and namespace state * tools/lab: continue guest install with offline packages * tools/lab: add A1 handover notes * tools/lab: run the real install.sh — signed offline apk mirror, virtio agent console, deferred install, PPPoE/PD ISP rework * tools/lab: lts base, virtio agent console, PPPoE + DHCPv6-PD ISP, lab.sh change, scenarios on lib.sh, A1c report Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * tools/lab: no host daemon config or services, isp --gw, 03 for same-subnet modems after #138 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * tools/lab: README links the product fixes #147 #148 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * tools/lab: review fixes — pinned downloads, image lock, pppd off the host's /run, cleanup on every exit - the cloud image and the minirootfs are fixed versions with pinned SHA256s (checked against Alpine's .sha512 / .sha256); the package chroot is always re-extracted from the verified tarball - one lock (mr-lab-images/.build.lock) for all shared image initialisation; temp dirs from mktemp; loop mounts on fresh mount points, unmounted by the exit trap - veth pairs are created inside the lab namespaces (ip -n <sw> link add ... peer ... netns <ns>) - pppoe-server and its pppd run with a private tmpfs /run: no /run/ppp0.pid or pppd2.tdb on the host - processes are stopped TERM first, KILL after 3 s; isp_stop / ns_del signal everything inside the lab namespace, pid files only a process whose name still matches; powercut goes through kill_qemu - host guard: INT/TERM/HUP run it in dash, symlinks under /etc/ppp, a baseline across commands (lab.sh guard-reset); up refuses to run next to host dnsmasq / kea / radvd services - scenarios: the lab is taken down on any exit (MRLAB_KEEP=1 keeps it), failed setup steps bail out - README: dependencies (mask services before installing; python3, openssh-client; no socat), download trust, host safety Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
install.sh: when PPPoE is chosen,pppoe_kernelrunsmodprobe -q pppoeand requires/proc/net/pppoe(registered per network namespace by the pppoe driver, built in or as a module; pppoe pulls in ppp_generic). Without it the installer stops before asking for the account, in Chinese and English, with the fix:apk add linux-lts && reboot(on*-virt: "the linux-virt kernel has no PPPoE"; otherwise also "reboot after a kernel upgrade"). TheMR_APPLY=0part is not touched.rootfs/etc/init.d/mr-pppoe:start_prefails with the same reason (alsologger -p daemon.err), so an apply that switches a WAN to PPPoE rolls back at once and says why.mr doctor: a PPPoE WAN without an address and without/proc/net/pppoereports "the kernel has no PPPoE (the pppoe module is not loaded)" with the fix instead of "cable, account, ISP". Test:TestDoctorPPPoEWithoutKernelSupport; the healthy fake environment now has/proc/net/pppoe.docs/install-alpine.md: one paragraph on the kernel requirement.Why
Alpine's
linux-virtkernel (cloud images, many VMs) is built with# CONFIG_PPPOE is not set. install.sh used to write the config, wait 90 s for a session that could never come up and roll back withPPPoE did not come up within 90s; only pppd's log saidCouldn't open the /dev/ppp device.Verification
sudo ./tools/ci.sh: ALL CHECKS PASSED (shellcheck of install.sh at-S warningclean). The new doctor test fails without the doctor change.linux-virt, PPPoE install: install.sh stops at step 3 with the message above, nothing applied.linux-virt, DHCP install, then the API switches the WAN to PPPoE: rolled back after 4 s withmr-pppoe.wan: … kernel 6.18.35-0-virt has no PPPoE (modprobe pppoe failed); Alpine: apk add linux-lts, reboot, also in/var/log/messages.linux-lts, PPPoE + DHCPv6-PD scenario: 8/8 (session, delegated prefix, client IPv4/IPv6, ping6 to the ISP)./proc/net/pppoeis right for built-in, module and namespaces; a built-in pppoe with a failing modprobe is not misreported; a failingstart_prekeeps supervise-daemon from respawning pppd every 5 s and does not block the boot.Closes #146
🤖 Generated with Claude Code